ci(rust): Auto-update rust-toolchain.toml #2746
Conversation
szokeasaurusrex
force-pushed
the
szokeasaurusrex/update-toolchain-action
branch
2 times, most recently
from
b6b64c1 to
8e765eb
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/update-toolchain-action
branch
from
8e765eb to
2484d23
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // Update rust-toolchain.toml | ||
| const fs = require('fs'); | ||
| const content = fs.readFileSync('rust-toolchain.toml', 'utf8'); | ||
| const updated = content.replace(/channel = "[\d.]+"/, `channel = "${newVersion}"`); |
There was a problem hiding this comment.
Bug: Regex Fails for Non-Numeric Rust Channels
The regex for updating rust-toolchain.toml is very specific, only matching numeric channels with double quotes and exact spacing. This means it might silently fail to update the file for common non-numeric channels (e.g., "stable") or if the file uses different formatting, leading to empty pull requests.
There was a problem hiding this comment.
I think this is okay, as our rust-toolchain.toml is formatted predictably
|
@szokeasaurusrex I'm ready to approve this but I see CI is failing here for some reason. Might be a flake? |
|
Yeah, test failures are unrelated, they were also failing on master last week. It seems to be failing consistently though, not a flake. Gonna investigate this. Autofixing new lints sounds like a good idea though! But maybe I'll make another PR to add that |
Automatically make PRs to bump the Rust toolchain version pinned in
rust-toolchain.toml.The PRs will look like #2748, which was generated against #2747, which builds on top of this PR.
Fixes CLI-167