Skip to content

fix(handicap): use aria-live to read handicap popup content #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(handicap): use aria-live to read handicap popup content #1230

wants to merge 1 commit into from

Conversation

danji90
Copy link
Contributor

@danji90 danji90 commented Sep 8, 2025

How to

Others

  • It's not a hack or at least an unauthorized hack :).
  • The images added are optimized.
  • Everything in ticket description has been fixed.
  • The author of the MR has made its own review before assigning the reviewer.
  • The title means something for a human being and follows the conventional commits specification.
  • The title contains [WIP] if it's necessary.
  • Labels applied. if it's a release? a hotfix?
  • Check the preview app on iOS before merge: Is everything working? SVGs visible?
  • Tests added.

@danji90 danji90 self-assigned this Sep 8, 2025
@vercel Vercel
Copy link

vercel bot commented Sep 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
dev-trafimage-maps Ready Ready Preview Comment Sep 8, 2025 0:34am
trafimage-maps Ready Ready Preview Comment Sep 8, 2025 0:34am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedjoff friedjoff Awaiting requested review from friedjoff friedjoff is a code owner

@oterral oterral Awaiting requested review from oterral oterral is a code owner

Assignees

@danji90 danji90

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danji90