Skip to content

Conversation

heyjorgedev
Copy link
Contributor

On my project I use Redis as my default cache store, I noticed that the package right now uses cache (the default store) to not compute the same thing all over again, but I think doing a network request to Redis is expensive, by making the cache store configurable you can optimize this to use the "file" store.

Just an idea, on my project solved it by extending the service provider and making my changes, but the package is awesome and wanted to contribute with this idea back

@heyjorgedev heyjorgedev force-pushed the configure-cache-store branch 2 times, most recently from 467f353 to 414c739 Compare March 16, 2024 13:15
@heyjorgedev
Copy link
Contributor Author

I even think that the default cache store for this package should be file but didn't want to do that change since there are already people using it

@heyjorgedev heyjorgedev force-pushed the configure-cache-store branch from 414c739 to 5d7d5b7 Compare March 20, 2024 03:54
@mt-shihab26
Copy link

I am also facing this problem. We need to make the cache store configurable. Why maintainer are not merging this pull request.

@eznix86
Copy link

eznix86 commented Sep 11, 2024

Hi maintainer, is it possible to be merged ?

@boolean-lukastajic
Copy link

It's been a while, merge the PR. People are eager 😄 !

@mrdoinel
Copy link

We are also facing the same issue. Can you please review and merge this one year old PR ?

@antonioribeiro
Copy link

Nice PR @heyjorgedev, thank you!

Can you make the caching optional, please?

It still forces us to define a cache store and even the "array" or APC stores could lead to calls that will take some unneeded process time.

@antonioribeiro
Copy link

Just to corroborate what I asked before about making the cache optional, @heyjorgedev , a word from Tim MacDonald when publishing the new memoized cached driver for Laravel 12 (which is great, but can also drive applications to have memory problems very quickly if not used properly):

"We put things in the cache because the cache is fast; that doesn't mean hitting the cache is free."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants