Skip to content

Conversation

resoluteCoder
Copy link
Collaborator

@resoluteCoder resoluteCoder commented Nov 4, 2024

This PR adds error messages for the unwrap functions as follows:

  • Used unwrap_or_err for functions that return results with an err.
  • Used expect for functions that return an option.
  • Used convention of x not found for error messages

Original reference PR: #241

Copy link
Collaborator

@declark1 declark1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a couple of comments inline to add detector_id to the error message.

@evaline-ju
Copy link
Collaborator

@resoluteCoder for a first contribution maintainers have to approve the workflow - could you look into the failing linting? It can also be debugged locally with cargo clippy --all-targets --all-features -- -D warnings thanks!

@evaline-ju evaline-ju merged commit f2010e1 into foundation-model-stack:main Nov 4, 2024
2 checks passed
@evaline-ju evaline-ju linked an issue Nov 4, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide more info for unwraps when they error
3 participants