Skip to content

Conversation

AsCress
Copy link
Collaborator

@AsCress AsCress commented Sep 18, 2025

Removes FOREGROUND_SERVICE_LOCATION from the Manifest as it isn't needed and is blocking us from pushing to the Play Store.

Adds NSLocationAlwaysAndWhenInUseUsageDescription in Info.plist as it is recommended by App Store Connect.

Summary by Sourcery

Update platform-specific permission declarations to comply with App Store and Google Play requirements

Bug Fixes:

  • Remove unused FOREGROUND_SERVICE_LOCATION permission from AndroidManifest to resolve Play Store submission issues

Enhancements:

  • Add NSLocationAlwaysAndWhenInUseUsageDescription key to iOS Info.plist for App Store compliance

@AsCress AsCress requested a review from marcnause September 18, 2025 06:14
@AsCress AsCress self-assigned this Sep 18, 2025
@AsCress AsCress added Fix Solution to an existing issue in app flutter labels Sep 18, 2025
Copy link
Contributor

sourcery-ai bot commented Sep 18, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR adjusts platform-specific configuration by removing an unneeded Android permission and adding a recommended iOS location usage description, directly updating the XML manifests to satisfy app store requirements.

File-Level Changes

Change Details Files
Removed unneeded Android foreground location permission
  • Deleted the FOREGROUND_SERVICE_LOCATION permission line
android/app/src/main/AndroidManifest.xml
Added iOS always-and-when-in-use location usage description
  • Inserted NSLocationAlwaysAndWhenInUseUsageDescription key
  • Added corresponding description string
ios/Runner/Info.plist

Possibly linked issues

  • feat: ported thermometer screen. #2761: The PR removes the FOREGROUND_SERVICE_LOCATION permission from the Android manifest, which was blocking Play Store deployment as described in the issue.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@AsCress AsCress enabled auto-merge (squash) September 18, 2025 06:14
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The iOS Info.plist string for NSLocationAlwaysAndWhenInUseUsageDescription is generic—consider tailoring it to explain why “always” location access is required to users.
  • Ensure your app’s iOS permission request flow actually asks for “always” authorization, otherwise the new Always-and-WhenInUse key may never be displayed.
  • There’s a typo in AndroidManifest: "ACCESS_COURSE_LOCATION" should be "ACCESS_COARSE_LOCATION".
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The iOS Info.plist string for NSLocationAlwaysAndWhenInUseUsageDescription is generic—consider tailoring it to explain why “always” location access is required to users.
- Ensure your app’s iOS permission request flow actually asks for “always” authorization, otherwise the new Always-and-WhenInUse key may never be displayed.
- There’s a typo in AndroidManifest: "ACCESS_COURSE_LOCATION" should be "ACCESS_COARSE_LOCATION".

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@AsCress
Copy link
Collaborator Author

AsCress commented Sep 18, 2025

Context for Info.plist changes:-
image

@AsCress AsCress merged commit 1bcfd8b into fossasia:flutter Sep 18, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Solution to an existing issue in app flutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants