-
Notifications
You must be signed in to change notification settings - Fork 812
fix: permissions for compliance #2928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR adjusts platform-specific configuration by removing an unneeded Android permission and adding a recommended iOS location usage description, directly updating the XML manifests to satisfy app store requirements. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The iOS Info.plist string for NSLocationAlwaysAndWhenInUseUsageDescription is generic—consider tailoring it to explain why “always” location access is required to users.
- Ensure your app’s iOS permission request flow actually asks for “always” authorization, otherwise the new Always-and-WhenInUse key may never be displayed.
- There’s a typo in AndroidManifest: "ACCESS_COURSE_LOCATION" should be "ACCESS_COARSE_LOCATION".
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The iOS Info.plist string for NSLocationAlwaysAndWhenInUseUsageDescription is generic—consider tailoring it to explain why “always” location access is required to users.
- Ensure your app’s iOS permission request flow actually asks for “always” authorization, otherwise the new Always-and-WhenInUse key may never be displayed.
- There’s a typo in AndroidManifest: "ACCESS_COURSE_LOCATION" should be "ACCESS_COARSE_LOCATION".
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
4747051
to
218b5c1
Compare
Removes
FOREGROUND_SERVICE_LOCATION
from the Manifest as it isn't needed and is blocking us from pushing to the Play Store.Adds
NSLocationAlwaysAndWhenInUseUsageDescription
in Info.plist as it is recommended by App Store Connect.Summary by Sourcery
Update platform-specific permission declarations to comply with App Store and Google Play requirements
Bug Fixes:
Enhancements: