Skip to content

Conversation

AsCress
Copy link
Collaborator

@AsCress AsCress commented Sep 16, 2025

Fixes #2907

Summary by Sourcery

Enhancements:

  • Adjust OscilloscopeScreen flex values to expand the waveform display area and reduce the tab panel width

@AsCress AsCress self-assigned this Sep 16, 2025
@AsCress AsCress added Feature New addition to the existing app flutter labels Sep 16, 2025
Copy link
Contributor

sourcery-ai bot commented Sep 16, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR fine-tunes the Oscilloscope screen layout by adjusting the flex ratios of the main content area and the tab panel to improve spacing and visual balance.

File-Level Changes

Change Details Files
Adjusted flex distribution between main content and tab section
  • Increased main content flex from 87 to 89
  • Decreased tab section flex from 13 to 11
lib/view/oscilloscope_screen.dart

Assessment against linked issues

Issue Objective Addressed Explanation
#2907 Optimize the Oscilloscope screen layout to better utilize space, including adjusting the width of the measurement screen view and the right menu choices.
#2907 Revert or adjust specific UI elements (dashed line style, top red bar height and font size, measurement area font size and spacing, bottom area height and font size, stop/pause icon, CH1/CH2 options, (i) symbol for Automated Measurements, Logged Data option, and measurement screen width) to match the previous app version. The diff only changes the flex values for the main measurement area and the right menu, affecting their relative widths. It does not address other UI elements such as dashed line style, top red bar, font sizes, stop/pause icon, CH1/CH2 options, (i) symbol, or Logged Data option.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

github-actions bot commented Sep 16, 2025

Build Status

Build successful. APKs to test: https://github.com/fossasia/pslab-app/actions/runs/17981380855/artifacts/4095199333.

Screenshots

Android Screenshots
iPhone Screenshots
iPad Screenshots

@mariobehling
Copy link
Member

Thanks, please provide screenshots when you finalize this PR.

@AsCress AsCress force-pushed the oscilloscope_layout branch from 3e13af6 to 81855b0 Compare September 24, 2025 14:04
@AsCress
Copy link
Collaborator Author

AsCress commented Sep 24, 2025

Old

Screenshot_20250924_225456

New

Screenshot_20250924_225257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New addition to the existing app flutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize design of Oscilloscope
2 participants