Skip to content

Public Schedule: Clicking on a filter moves the page #5826 #5849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Public Schedule: Clicking on a filter moves the page #5826 #5849

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2409273
add ember-router-scroll
akash2408 Dec 1, 2020
07db880
Update sessions.js
akash2408 Dec 1, 2020
ef35cdd
Update sessions.js
akash2408 Dec 1, 2020
85e8bb0
Update sessions.js
akash2408 Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions app/controllers/public/sessions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,10 @@ export default class SessionsController extends Controller {

@action
sessionChanged() {
if (this.model.isFiltering) {
$('html,body').animate({
scrollTop: $('#session-heading').offset()?.top
});
}
this.set('preserveScrollPosition', true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why created this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After only removing session changed whenever we click on filter page will reload and moves up using previous scoll position this well save the earlier scroll postion of page and didnt moves the page up and down

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right. 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work @akash2408

$('html,body').animate({
scrollTop: $('#session-heading').offset()?.top
});
}

@computed('model.event.startsAt', 'model.event.endsAt', 'timezone')
Expand Down