fix: Show social links as icon

[sachinchauhan2889]

Fixes #5785
Fixes #5824

screenshots

Checklist

• I have read the Contribution & Best practices Guide.
• My branch is up-to-date with the Upstream development branch.
• The acceptance, integration, unit tests and linter pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/lwnslhcti
✅ Preview: https://open-event-frontend-git-right-side-bar-enhance.eventyay.now.sh

[lgtm-com]

This pull request introduces 1 alert when merging d1c65ec into 4c59354 - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[sachinchauhan2889]

confused about social links icons.
semantic ui provide only buttons for only few social links mentioned in our projects. example :- for twitter, facebook, linked etc. but not for github, gitter etc..
it looks like this.

we can also use this icon buttons..

please suggest which icon buttons needed from above choices

[codecov]

Codecov Report

Merging #5812 (839b792) into development (f17e24c) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

@@               Coverage Diff               @@
##           development    #5812      +/-   ##
===============================================
- Coverage        23.43%   23.41%   -0.03%     
===============================================
  Files              512      511       -1     
  Lines             5466     5471       +5     
  Branches            65       65              
===============================================
  Hits              1281     1281              
- Misses            4168     4173       +5     
  Partials            17       17              

Impacted Files	Coverage Δ
app/controllers/public.js	0.00% <0.00%> (ø)
app/models/social-link.js	0.00% <0.00%> (ø)
app/utils/dictionary/social-media.ts	92.85% <100.00%> (+0.54%)	⬆️
app/routes/events/view/edit/sessions-speakers.js	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f17e24c...839b792. Read the comment docs.

[divyamtayal]

I think if UI-semantic does not have all the social link button then u should go with the one where all eh buttons are the same so that style is consistent for all buttons

[iamareebjamal]

You can always set the button color using CSS. For links present in socialMediaIdentifier, please use an icon, for others let them be as they are now.

So, use this style

And set color using classes or CSS, for eg, GitHub black, GitLab orange, Gitter pink

For custom links, show them as they are shown already

[lgtm-com]

This pull request introduces 1 alert when merging 31be621 into f17e24c - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[sachinchauhan2889]

@iamareebjamal sir, please review

[divyamtayal]

Pls make all the boxes to be of the same size

[iamareebjamal]

No need of quotes in keys without space

[iamareebjamal]

Why looping 2 times, use if else in a single loop

[sachinchauhan2889]

@iamareebjamal sir,
variable socialLinks contains both links socialMedia links and custom URLs.
i have made a flex-box for icon buttons. first of all I inserted event-site-URL. then i traverse all socialLinks and only select SocialMedia links to put inside flex-box as icon buttons. then outside of flex-box i traverse all socialLinks and only select Custom-URLs and list them. how can i do this in one loop.
we can store custom-URLs in a variable while first loop and use them outside felx-box. this will be complex in hbs. thats why i use 2 loops.

[iamareebjamal]

OK, I understand now

[sachinchauhan2889]

[iamareebjamal]

@mariobehling Shouldn't we show the custom links like we previously did?

Like if there are 4 custom links:
Page, Support, About, Contact

They all will show Event Site. The UI will be confusing and there will be no use of freeform input of site name

[iamareebjamal]

@sachinchauhan2889 Please just show social media links in this PR and continue showing custom links in previous form. We'll discuss the other issue in next PR

[sachinchauhan2889]

@sachinchauhan2889 Please just show social media links in this PR and continue showing custom links in previous form. We'll discuss the other issue in next PR

@iamareebjamal sir, customs links are already in previous form. you can check

[iamareebjamal]

OK, I understand it completely now.

[mariobehling]

Very nice! Thank you.