Skip to content

fix: set url to null instead of https when it is null #5804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 2, 2020
Merged

fix: set url to null instead of https when it is null #5804

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
56de96c
wip: set url to null instead of https when it is null
maze-runnar Nov 28, 2020
dff90e2
f
maze-runnar Nov 28, 2020
c25bd49
null set
maze-runnar Nov 28, 2020
0808091
f
maze-runnar Nov 29, 2020
a245072
final working
maze-runnar Nov 29, 2020
1243d74
f
maze-runnar Nov 29, 2020
c3c3b5b
t
maze-runnar Nov 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app/components/widgets/forms/link-field.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { socialMediaExtraPrefixes } from 'open-event-frontend/utils/dictionary/s
interface Args {
prefix: string | undefined,
value: string | undefined,
onChange: (text: string) => void
onChange: (text: string | null) => void
}

export default class LinkField extends Component<Args> {
Expand Down Expand Up @@ -63,7 +63,11 @@ export default class LinkField extends Component<Args> {
setValue(event: { target: HTMLInputElement }): void {
const text = event.target.value;
this.value = this.fixValue(text);
this.args.onChange(this.finalValue);
if (this.value) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.value ? this.finalValue : this

Copy link
Contributor Author

@maze-runnar maze-runnar Nov 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is showing

Type 'this' is not assignable to type 'string'.
  Type 'LinkField' is not assignable to type 'string'.

this.args.onChange(this.finalValue);
} else {
this.args.onChange(null);
}
}

@action
Expand Down