Skip to content

Conversation

MeghalBisht
Copy link
Member

Fixes #5780

Short description of what this resolves:

Sales in orders now shows 0.00 instead of 0 if the income of sales has been zero.

After :
2020-11-27

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/msqqj39s7
✅ Preview: https://open-event-frontend-git-sales-5780.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #5784 (6489824) into development (91fb290) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5784   +/-   ##
============================================
  Coverage        23.45%   23.45%           
============================================
  Files              512      511    -1     
  Lines             5445     5449    +4     
  Branches            63       63           
============================================
+ Hits              1277     1278    +1     
- Misses            4152     4155    +3     
  Partials            16       16           
Impacted Files Coverage Δ
app/controllers/events/view/tickets/index.js 0.00% <0.00%> (ø)
app/helpers/general-date.js 66.66% <0.00%> (-33.34%) ⬇️
app/helpers/header-date.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91fb290...6489824. Read the comment docs.

@iamareebjamal iamareebjamal changed the title fix : Show 0.00 instead of 0 for Sales fix: Show 0.00 instead of 0 for Sales Nov 27, 2020
@auto-label auto-label bot added the fix label Nov 27, 2020
@iamareebjamal
Copy link
Member

Please use proper PR title format, there is no space before :

@iamareebjamal iamareebjamal merged commit d427ea6 into fossasia:development Nov 27, 2020
@MeghalBisht
Copy link
Member Author

Please use proper PR title format, there is no space before :

Will keep that in mind, thanks!

@MeghalBisht MeghalBisht deleted the sales-5780 branch November 27, 2020 21:27
@mariobehling
Copy link
Member

After the merge the $ sign is back. Or where does it come from again? Many events are not using Dollars.

Screenshot from 2020-11-28 00-46-13

@mariobehling
Copy link
Member

Or was it another recent PR? Cannot find where the change happened.

@iamareebjamal
Copy link
Member

Regression #5453 because of this PR. There needs to be a test for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organizers Orders Dashboard: Show 0.00 instead of 0 for Sales
3 participants