-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: Localize Date and Time translations using AM/PM #5748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
iamareebjamal
merged 23 commits into
fossasia:development
from
divyamtayal:trans-date-5491
Nov 27, 2020
Merged
Changes from 22 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
23e7c0f
Start
ad17eba
Merge branch 'development' into trans-date-5491
8760c75
Changed to 24h
f07c128
Changed to 24h-1
8c324bf
Fix test
e71f3a1
Update .env.example
130bd01
Merge branch 'development' into trans-date-5491
03aa56f
Improved Code
f06a783
Improved code-1
f2f5c68
code cleanup-1
3f16129
Merge branch 'development' into trans-date-5491
163699e
Replace header-date with general-date
ac4f96d
Replace moment-format with general-date
8b8d6c5
Fix and Improoved test
b4647d7
Improved Date format
ff36d5f
Deleted header-date helper
888122f
Fixed Test
64bde57
Revert default format
70f296c
Revert changes
fe0a542
Revert "Revert changes"
d6909bf
Finalizing the PR
fdc6fc0
Deleted header-date helper
fe1151a
Added format for all replaced header-date
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
<span> | ||
{{moment-format this.record 'D MMM, YYYY h:mm A'}} | ||
{{general-date this.record '' 'D MMM, YYYY h:mm A'}} | ||
<br>To<br> | ||
{{moment-format this.extraRecords.validTill 'D MMM, YYYY h:mm A'}} | ||
{{general-date this.extraRecords.validTill '' 'D MMM, YYYY h:mm A'}} | ||
</span> |
4 changes: 2 additions & 2 deletions
4
app/templates/components/ui-table/cell/events/view/tickets/attendees/cell-date.hbs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{{#if (eq @record.status 'completed')}} | ||
{{moment-format @record.completedAt "D MMM, YYYY h:mm A"}} | ||
{{general-date @record.completedAt '' "D MMM, YYYY h:mm A"}} | ||
{{else}} | ||
{{moment-format @record.createdAt "D MMM, YYYY h:mm A"}} | ||
{{general-date @record.createdAt '' "D MMM, YYYY h:mm A"}} | ||
{{/if}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
app/templates/components/ui-table/cell/events/view/tickets/discount-codes/cell-validity.hbs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
<span> | ||
{{moment-format this.record 'D MMM, YYYY h:mm A'}} | ||
{{general-date this.record '' 'D MMM, YYYY h:mm A'}} | ||
</span> |
4 changes: 2 additions & 2 deletions
4
app/templates/components/ui-table/cell/events/view/tickets/orders/cell-date.hbs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
{{#if this.record}} | ||
<div> | ||
{{moment-format this.record 'MMMM DD, YYYY - hh:mm A'}} | ||
{{general-date this.record '' 'D MMM, YYYY h:mm A'}} | ||
</div> | ||
{{else}} | ||
<div> | ||
{{moment-format this.extraRecords.createdAt 'MMMM DD, YYYY - hh:mm A'}} | ||
{{general-date this.extraRecords.createdAt '' 'D MMM, YYYY h:mm A'}} | ||
</div> | ||
{{/if}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.