Skip to content

fix: Change acknowledgement text and button #5611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 22, 2020
Merged

fix: Change acknowledgement text and button #5611

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
be2588a
Acknowledgement Text and Button
Saumyachitransh01 Nov 13, 2020
d17f03c
Internal Links added
Saumyachitransh01 Nov 15, 2020
069962c
Links
Saumyachitransh01 Nov 15, 2020
744b672
Resolving Repetition
Saumyachitransh01 Nov 20, 2020
70cd61a
Update order-form.hbs
Saumyachitransh01 Nov 20, 2020
260e2be
Update order-form.hbs
Saumyachitransh01 Nov 20, 2020
660fb29
Update order-form.hbs
Saumyachitransh01 Nov 20, 2020
5251661
link placeholder
Saumyachitransh01 Nov 22, 2020
934a87a
terms privacy
Saumyachitransh01 Nov 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions app/templates/components/forms/orders/order-form.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,12 +279,13 @@
{{t 'Acknowledgement'}}
</h4>
<p>
{{t
'By clicking "Pay Now", I acknowledge that I have read and that I agree with all the terms of services and privacy policy of Open Event.'}}
</p>
{{t 'By clicking'}}{{#if this.isPaidOrder}} {{t ' "Proceed to Checkout"'}} {{else}} {{t ' "Order Now"'}}{{/if}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a single message with placeholders like here https://github.com/Cropster/ember-l10n#singular-translations

{{t ', I acknowledge that I have read and that I agree with the '}}
<a href='/terms'>terms of services</a>{{t ' and ' }}<a href='/privacy'>privacy policy</a> {{t ' on this website.'}}
</p>
<div class="center aligned">
<button type="submit" class="ui teal submit button">{{t 'Proceed to Checkout'}}</button>
<button type="submit" class="ui teal submit button">{{#if this.isPaidOrder}} {{t "Proceed to Checkout"}} {{else}} {{t "Order Now"}}{{/if}}</button>
</div>
</div>
</div>
</div>
</form>