Skip to content

fix: No error shown when image upload fails #5595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2020
Merged

fix: No error shown when image upload fails #5595

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d76c024
add error message on profile image
akash2408 Nov 12, 2020
b5f1f01
show error message if image not upload
akash2408 Nov 12, 2020
d02883f
Update app/components/widgets/forms/image-upload.js
iamareebjamal Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/components/widgets/forms/image-upload.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,9 @@ export default class ImageUpload extends Component {
})
.catch(e => {
console.error('Error while uploading and setting image URL', e);
this.notify.error(this.l10n.t('Error while uploading and setting image URL'));
this.set('uploadingImage', false);
this.set('errorMessage', this.i18n.t('An unexpected error has occurred.'));
this.set('selectedImage', null);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why

});
}

Expand Down