fix: simplify sponsor box

[maze-runnar]

Fixes #5462

Checklist

• I have read the Contribution & Best practices Guide.
• My branch is up-to-date with the Upstream development branch.
• The acceptance, integration, unit tests and linter pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/3k61ezqy9
✅ Preview: https://open-event-frontend-git-sponsor-box.eventyay.vercel.app

[codecov]

Codecov Report

Merging #5466 (bd334e2) into development (7d49a44) will increase coverage by 0.04%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development    #5466      +/-   ##
===============================================
+ Coverage        23.71%   23.75%   +0.04%     
===============================================
  Files              498      498              
  Lines             5255     5246       -9     
  Branches            44       44              
===============================================
  Hits              1246     1246              
+ Misses            4003     3994       -9     
  Partials             6        6              

Impacted Files	Coverage Δ
app/controllers/events/view/index.js	0.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d49a44...6b6aa49. Read the comment docs.

[mariobehling]

• Please use the same spacing to the box edge for the "Edit" button as in other boxes
• Please decrease the space between previous/next button and the above table

[iamareebjamal]

Why the need for inline styles?

[iamareebjamal]

Delete the commented lines please

[iamareebjamal]

@maze-runnar Please check the comments from @mariobehling and me about spacing and inline styles. Please try to reduce request review cycles

[iamareebjamal]

I know it is for overriding CSS, but it shouldn't be needed

[iamareebjamal]

Code looks good to me. Please resolve conflicts

[mariobehling]

Let's try to standardize the design.

• Please make the table width the same width as the table in the above box.
• Please use the entire width of the table
  • expand the width of the sponsor names
  • move Type and Level to the right
• Reduce the space of the previous/next buttons to the above table

[mariobehling]

I see the non-functional search box we already got rid of is back. It seems like you are working on different versions, cause I do not see it in your screenshot.

[maze-runnar]

• Please make the table width the same width as the table in the above box.

@iamareebjamal i have already used 15 wide column class, now for this I have to add width css.

[iamareebjamal]

Go ahead

[maze-runnar]

Reduce the space of the previous/next buttons to the above table

@iamareebjamal what about this? the space is kind of fix for every table.

[maze-runnar]

• Reduce the space of the previous/next buttons to the above table this is remaining to do.But it will change it in every place
  

[iamareebjamal]

Yes, reduce it for every table please

[iamareebjamal]

Screenshot? Also I think the only thing which was needing change was pagination padding, what effect does changing table padding have in other sections of the site?

[maze-runnar]

[mariobehling]

According to your screenshots you are working with outdated code, which is confusing for me when I review it. So, I am updating the branch.

[mariobehling]

There are few small issues. Maybe it is difficult for you to see it, but usually from a design perspective across all boxes the spacing of the heading and text should be the same. Below table spacing should be the same as the spacing of the heading. I tried to show it in my previous screenshot. I do not know how to make it clearer.

Could you also please do the following, please:

• Delete the column "Level" (sorry for the addition, but looking over it carefully, it does not really seem necessary here)
• Make the "Name" column wider. We have lots of space left on the right-hand side.
• Ensure the list really only shows the number of sponsors that are chosen: Here it shows "10", but 11 sponsors are shown in the box. There is an error somewhere.

[iamareebjamal]

@mariobehling Are you talking about the space between the navigation panel and the end of the table? That is part of the table UI and independent of the sponsors section. The space was already reduced and can be reduced further, but it'll stay independent of the space above the table, and for example, look different in other parts of the UI. So, we can make it look equal here but then it'll make it look unequal in other parts of the UI wherever the table is used, so it's a question of trade-off and we can only use a constant spacing in the component.

About the 11 sponsors, that is another issue but can be taken in this as well, but it is not a UI change mentioned in the issue or something which broke due to these changes.

[mariobehling]

@iamareebjamal I will file a separate issue later about standardization of design on dashboard. Thanks for taking in things that were not in the original issue! Appreciate it.