Skip to content

Conversation

terminator0309
Copy link
Contributor

@terminator0309 terminator0309 commented Oct 18, 2020

Fixes #5013

Short description of what this resolves:

Simplifies wizard Step 3 and 5

Changes proposed in this pull request:

  1. Wizard step 3 : demoted "Add Custom form field" from heading to standard text.
  2. Wizard step 5 : "Customize registration form" renamed to -> "Customize submission forms"

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Oct 18, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/mglto8h9o
✅ Preview: https://open-event-frontend-git-wizard-enhancement.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Oct 18, 2020

Codecov Report

Merging #5334 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5334   +/-   ##
============================================
  Coverage        22.78%   22.78%           
============================================
  Files              491      491           
  Lines             5245     5245           
  Branches            37       37           
============================================
  Hits              1195     1195           
  Misses            4045     4045           
  Partials             5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 084c701...f7ec27c. Read the comment docs.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please resolve conflicts.

</div>
</div>
{{/each}}
<br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change indentation unnecessarily. I can't see what's your change and what's just indentation change. Revert to original indentation and just make your changes in the PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for that, actually i use Prettier and as soon as i saved the changes it formatted everything. I will make a new PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for a new PR, push changes to this PR itself

Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary indentation changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wizard Form: Simplify design
3 participants