-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: add bottom margin overflow in hastags of event-cards #5289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add bottom margin overflow in hastags of event-cards #5289
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/pmz5tusl6 |
Codecov Report
@@ Coverage Diff @@
## development #5289 +/- ##
===============================================
- Coverage 22.85% 22.80% -0.06%
===============================================
Files 491 491
Lines 5241 5241
Branches 37 37
===============================================
- Hits 1198 1195 -3
- Misses 4038 4041 +3
Partials 5 5
Continue to review full report at Codecov.
|
Now, it can create layout issues in grid. |
|
app/styles/partials/event-card.scss
Outdated
|
||
span { | ||
|
||
&:last-child { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use a class, no need for a complicated selector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamareebjamal Done sir, please check now.
Keep PR titles short, to the point and according to the format |
Yes, Sir, I will keep that in mind from next time. |
Fixes #2346
Short description of what this resolves:
The proposed change in code will add a bottom margin as well as prevent the overflow of hashtags from the even cards.
Changes proposed in this pull request:
Old View
New View