Skip to content

Conversation

ShreyanshSrivastava
Copy link
Contributor

Fixes #2346

Short description of what this resolves:

The proposed change in code will add a bottom margin as well as prevent the overflow of hashtags from the even cards.

Changes proposed in this pull request:

  • Instead of fixing the height of the card, make it auto to adjust it according to the size of the contents inside the card.

Old View

old-view

New View

new-view

@vercel
Copy link

vercel bot commented Oct 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/pmz5tusl6
✅ Preview: https://open-event-frontend-git-event-cards-margin-bottom.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Oct 11, 2020

Codecov Report

Merging #5289 into development will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5289      +/-   ##
===============================================
- Coverage        22.85%   22.80%   -0.06%     
===============================================
  Files              491      491              
  Lines             5241     5241              
  Branches            37       37              
===============================================
- Hits              1198     1195       -3     
- Misses            4038     4041       +3     
  Partials             5        5              
Impacted Files Coverage Δ
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4909ef8...255a52b. Read the comment docs.

@iamareebjamal
Copy link
Member

Now, it can create layout issues in grid.

@iamareebjamal
Copy link
Member

image

@ShreyanshSrivastava
Copy link
Contributor Author

Now, it can create layout issues in the grid.
@iamareebjamal Sir please check now, I have proposed another way which will not disturb the layout as well as prevent hashtags from flowing out.

@ShreyanshSrivastava
Copy link
Contributor Author

view
This is preventing the hashtags from overflow as well as not disturbing the grid layout


span {

&:last-child {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use a class, no need for a complicated selector

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal Done sir, please check now.

@iamareebjamal iamareebjamal changed the title added bottom margin and prevent overflow of hastags in event-cards on homepage fix: add bottom margin overflow in hastags of event-cards Oct 13, 2020
@auto-label auto-label bot added the fix label Oct 13, 2020
@iamareebjamal
Copy link
Member

Keep PR titles short, to the point and according to the format

@ShreyanshSrivastava
Copy link
Contributor Author

ShreyanshSrivastava commented Oct 13, 2020

Keep PR titles short, to the point, and according to the format

Yes, Sir, I will keep that in mind from next time.
@iamareebjamal please merge this branch with fossasia:development

@iamareebjamal iamareebjamal merged commit 59c3c86 into fossasia:development Oct 14, 2020
@ShreyanshSrivastava ShreyanshSrivastava deleted the event-cards-margin-bottom branch October 23, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bottom margin to event tags in event card
2 participants