Skip to content

Conversation

Saksham-Sirohi
Copy link
Contributor

@Saksham-Sirohi Saksham-Sirohi commented Jun 23, 2025

Fixes part of #359

image

image

Summary by Sourcery

Upgrade the cfp_flow frontend implementation to use Vue 3, modernizing component structure and reactivity patterns, and adjust related template and style handling.

Enhancements:

  • Migrate cfp_flow JavaScript from Vue 2 to Vue 3, updating component registration and reactivity usage.

Build:

  • Remove CSS compression for flow.css in the template.

Copy link

sourcery-ai bot commented Jun 23, 2025

Reviewer's Guide

This PR migrates the cfp_flow feature from Vue2 to Vue3 by switching to reactive state management and createApp-based initialization, modernizing component definitions and templates, and updating related static assets and the vendored Vue library.

Class diagram for updated Vue3 component structure in cfp_flow

classDiagram
    class FieldComponent {
        +template
        +props
        +data
        +computed
        +methods
    }
    class StepComponent {
        +template
        +props
        +data
        +computed
        +methods
    }
    class App {
        +template
        +data
        +computed
        +methods
    }
    App o-- FieldComponent : uses
    App o-- StepComponent : uses
    StepComponent o-- FieldComponent : uses
Loading

File-Level Changes


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Change Details Files
Migrate flow initialization and state to Vue3 patterns
  • Replace Vue.observable with Vue.reactive for currentModal
  • Switch from new Vue({el:…}) to Vue.createApp() and mount()
  • Replace Vue.set() calls with direct property assignments
src/pretalx/static/orga/js/cfp_flow.js
Refactor field and step components to modern Vue3 syntax
  • Convert Vue.component(...) into const component objects
  • Register components via app.component() instead of global Vue.component()
  • Wrap v-for elements in and refine v-if usage
src/pretalx/static/orga/js/cfp_flow.js Remove Django CSS compression and adjust flow.css
  • Remove {% compress %} tags around flow.css in template
  • Update flow.html to link flow.css directly
  • Add width: 100% rule in flow.css stylesheet
src/pretalx/orga/templates/orga/cfp/flow.html
src/pretalx/static/orga/css/flow.css
Upgrade vendored Vue library to Vue3
  • Replace old Vue2 vendor build with latest Vue3 vue.min.js
src/pretalx/static/vendored/vue.min.js

@Saksham-Sirohi Saksham-Sirohi marked this pull request as draft June 24, 2025 08:31
@Saksham-Sirohi Saksham-Sirohi force-pushed the cfp_flow_vue_migration branch from 4e43615 to 8ff3df0 Compare June 24, 2025 13:45
@Saksham-Sirohi Saksham-Sirohi marked this pull request as ready for review June 25, 2025 15:54
@mariobehling
Copy link
Member

Please share screenshots showing the feature functioning .

Copy link
Member

@hongquan hongquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Please add a blank line at the end of file.

@Saksham-Sirohi Saksham-Sirohi requested a review from hongquan June 27, 2025 08:09
@hongquan
Copy link
Member

hongquan commented Jul 3, 2025

@Saksham-Sirohi After the rewrite of Git history in FOSSASIA repo, your PR is now detected as 433 files difference from the target branch. Please rebase (git rebase command) your branch against the main branch and force push again.

@Saksham-Sirohi Saksham-Sirohi force-pushed the cfp_flow_vue_migration branch 2 times, most recently from 775750e to b7b3e70 Compare July 4, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants