Skip to content

Conversation

saramaebee
Copy link
Contributor

Overview

Fixes a bash syntax error in the Maven documentation where fossa analyze was incorrectly on the same line as the export statement.

Acceptance criteria

Users can now copy and execute the Maven MAVEN_ARGS example without syntax errors.

Testing plan

  1. Found the syntax error on line 42 of docs/references/strategies/languages/maven/maven.md
  2. Split the export and command onto separate lines
  3. Verified correct bash syntax

Risks

None - minor documentation fix only.

References

  • TKT-13372: Customer reported syntax error in Maven documentation

Corrected bash syntax error in MAVEN_ARGS example where command was
incorrectly placed on same line as export statement.
@saramaebee saramaebee requested a review from a team as a code owner May 30, 2025 22:37
@saramaebee saramaebee requested a review from james-fossa May 30, 2025 22:37
Copy link
Contributor

@spatten spatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but I think a better fix is to keep it on one line and remove the export. Like this:

MAVEN_ARGS="--settings /foo/bar/settings.xml" fossa analyze

This is safer as the MAVEN_ARGS environment variable is only set for this one line. If I export it, it's set for the rest of the script

Copy link
Contributor

@james-fossa james-fossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd defer to Scott on this one

@saramaebee saramaebee requested a review from spatten June 27, 2025 16:37
Copy link
Contributor

@spatten spatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

@zlav zlav enabled auto-merge (squash) July 30, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants