Skip to content

Conversation

victorspringer
Copy link
Contributor

@victorspringer victorspringer commented Sep 9, 2025

Adresses issue #846

Description

  • Problem: On Flutter Web, entering or exiting fullscreen can stall playback or force a pause; users often need to manually pause -> play to recover.
  • Root cause: The platform view rebuild during fullscreen disrupts the HTML video element’s stream/state.

Solution

  • Enter fullscreen (web-only): After the first fullscreen frame, force a quick pause -> 10ms delay -> play if the video was previously playing; if it was paused, briefly play then pause to prime a frame.
  • Exit fullscreen (web-only): Re-initialize the VideoPlayerController, seek back to the previous position, and restore the prior play/pause state.
  • All changes are guarded by kIsWeb; non-web platforms are unaffected.

Copy link
Collaborator

@diegotori diegotori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

codecov bot commented Sep 9, 2025

Codecov Report

❌ Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.03%. Comparing base (d51d4e5) to head (6ceb832).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
lib/src/chewie_player.dart 0.00% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #927      +/-   ##
==========================================
- Coverage   44.47%   44.03%   -0.45%     
==========================================
  Files          21       21              
  Lines        1585     1601      +16     
==========================================
  Hits          705      705              
- Misses        880      896      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@diegotori diegotori merged commit b8b967b into fluttercommunity:master Sep 9, 2025
2 of 5 checks passed
diegotori added a commit that referenced this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants