feat: expose rtc video value #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the video track is sometimes rotated internally. Without access to rotation or the computed aspectRatio, it's difficult to know the actual size of the video
holzgeist
added a commit
to holzgeist/flutter-webrtc
that referenced
this pull request
Jan 28, 2025
This was referenced Jan 28, 2025
|
If |
cloudwebrtc
pushed a commit
to flutter-webrtc/flutter-webrtc
that referenced
this pull request
Jan 29, 2025
daniel-g-favoreto-opl
pushed a commit
to daniel-g-favoreto-opl/flutter-webrtc
that referenced
this pull request
Mar 24, 2025
cloudwebrtc
pushed a commit
to livekit/client-sdk-flutter
that referenced
this pull request
Jul 31, 2025
This allows external users to e.g. apply rounded edges. Without this patch, VideoTrackRenderer will expand to its available space with no way (known to me..) for parent widgets to know how large the video actually is. depends on flutter-webrtc/flutter-webrtc#1754 (and flutter-webrtc/webrtc-interface#30)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the video track is sometimes rotated internally. Without access to rotation or the computed aspectRatio, it's difficult to know the actual size of the video