Skip to content

Media Recording Changes #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2025
Merged

Media Recording Changes #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14ca0f7
change media recorder
daniel-g-favoreto-opl Apr 4, 2025
700d8d6
add throw message
daniel-g-favoreto-opl Apr 4, 2025
e7f14eb
review changes
daniel-g-favoreto-opl Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lib/src/media_recorder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,16 @@ class MediaRecorder extends _interface.MediaRecorder {
final _interface.MediaRecorder _delegate;

@override
Future<void> start(String path,
{MediaStreamTrack? videoTrack, RecorderAudioChannel? audioChannel}) =>
Future<void> start(
String path, {
MediaStreamTrack? videoTrack,
RecorderAudioChannel? audioChannel,
}) =>
_delegate.start(path, videoTrack: videoTrack, audioChannel: audioChannel);

@override
Future stop() => _delegate.stop();
Future stop({String? albumName}) =>
_delegate.stop(albumName: albumName ?? 'FlutterWebRtc');

@override
void startWeb(
Expand Down
4 changes: 1 addition & 3 deletions lib/src/media_recorder_impl.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@ class MediaRecorderWeb extends MediaRecorder {
Future<void> start(
String path, {
MediaStreamTrack? videoTrack,
MediaStreamTrack? audioTrack,
RecorderAudioChannel? audioChannel,
int? rotation,
}) {
throw 'Use startWeb on Flutter Web!';
}
Expand Down Expand Up @@ -64,7 +62,7 @@ class MediaRecorderWeb extends MediaRecorder {
}

@override
Future<dynamic> stop() {
Future<dynamic> stop({String? albumName}) {
_recorder.stop();
return _completer.future;
}
Expand Down