Skip to content

feat: support postgresql url prefix #3354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2024
Merged

feat: support postgresql url prefix #3354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/storage/sql/db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ func init() {
// drop references to lib/pq and relay on pgx
dburl.Unregister("postgres")
dburl.RegisterAlias("pgx", "postgres")
dburl.RegisterAlias("pgx", "postgresql")
}

// Open opens a connection to the db
Expand Down
25 changes: 25 additions & 0 deletions internal/storage/sql/db_internal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,31 @@ func TestParse(t *testing.T) {
driver: SQLite,
dsn: "flipt.db?_fk=true&cache=shared&mode=rwc",
},
{
name: "postgresql url",
cfg: config.DatabaseConfig{
URL: "postgresql://postgres@localhost:5432/flipt?sslmode=disable",
},
driver: Postgres,
dsn: "postgres://postgres@localhost:5432/flipt?binary_parameters=yes&sslmode=disable",
},
{
name: "postgresql url prepared statements enabled",
cfg: config.DatabaseConfig{
URL: "postgresql://postgres@localhost:5432/flipt?sslmode=disable",
PreparedStatementsEnabled: true,
},
driver: Postgres,
dsn: "postgres://postgres@localhost:5432/flipt?sslmode=disable",
},
{
name: "postgresql no disable sslmode",
cfg: config.DatabaseConfig{
URL: "postgresql://postgres@localhost:5432/flipt",
},
driver: Postgres,
dsn: "postgres://postgres@localhost:5432/flipt?binary_parameters=yes",
},
{
name: "postgres url prepared statements enabled",
cfg: config.DatabaseConfig{
Expand Down
Loading