Skip to content

Conversation

causton81
Copy link
Contributor

I needed this patch to get streaming to work with flipt v2.1.0.
Also needed flipt-io/flipt#4715

@causton81 causton81 requested a review from a team as a code owner September 9, 2025 22:57
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 9, 2025
@dosubot dosubot bot added the bug Something isn't working label Sep 9, 2025
Copy link

dosubot bot commented Sep 9, 2025

Related Documentation

Checked 3 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

Copy link
Contributor

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @causton81 ! idk how we missed this! I must have tested with the now defunct Flipt Cloud which id use this format /internal/v1/evaluation/snapshots?[]namespaces={}

can you sign the DCO and assuming all tests pass we can merge and create a new release of all the sdks?

thank you again!

@erka erka changed the title fix(streaming): updated streaming endpoint URL fix(engine-ffi): updated streaming endpoint URL Sep 10, 2025
@erka
Copy link
Collaborator

erka commented Sep 10, 2025

@causton81 thank for you for this contribution. Could you please sign the commit off and force pushed it to the branch so we could merge it?

@markphelps
Copy link
Contributor

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~1 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin v2

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.69%. Comparing base (f701007) to head (1d116e1).
⚠️ Report is 610 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1314      +/-   ##
==========================================
- Coverage   80.36%   74.69%   -5.67%     
==========================================
  Files           8       10       +2     
  Lines        4165     4415     +250     
==========================================
- Hits         3347     3298      -49     
- Misses        818     1117     +299     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@causton81
Copy link
Contributor Author

@markphelps , I see Signed-off-by: Chris Auston <[email protected]> in my rebased commit. Is that what you need?

@markphelps
Copy link
Contributor

@causton81 oh i think its an email mismatch, I'll just mark the DCO as accepted because you signed off anyways

Commit sha: [1d116e1](https://github.com/flipt-io/flipt-client-sdks/pull/1314/commits/1d116e16e5d920995c2c5be9ee96d51f8b6655bd), Author: Chris AUSTON, Committer: Chris AUSTON; Expected "Chris AUSTON [[email protected]](mailto:[email protected])", but got "Chris Auston [[email protected]](mailto:[email protected])".

Copy link
Contributor

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you !!!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 10, 2025
@erka erka added the automerge label Sep 10, 2025
@kodiakhq kodiakhq bot merged commit ff7a7f5 into flipt-io:main Sep 10, 2025
35 checks passed
Copy link

dosubot bot commented Sep 10, 2025

Documentation Updates

Checked 3 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

@markphelps
Copy link
Contributor

@claude can you fix the streaming URL and response type for our Go client SDK ? similar to the fixes made in this PR?

Copy link
Contributor

claude bot commented Sep 10, 2025

Claude finished @markphelps's task —— View jobclaude/pr-1314-20250910-2112Create PR ➔


Tasks

  • Analyze the changes from PR fix(engine-ffi): updated streaming endpoint URL #1314 to understand the fix needed
  • Find the Go client SDK streaming implementation
  • Apply similar URL and response type fixes to the Go SDK
  • Format the Go code
  • Commit and push changes
  • Create PR link

Changes Made:

  1. URL Path: Updated from /internal/v1/evaluation/snapshots?[]namespaces=%s to /client/v2/environments/%s/namespaces/%s/stream

  2. Response Format: Simplified streamChunk struct to expect {result: <Document>} format instead of the nested namespaces map

  3. Stream Processing: Updated to directly use the result field as the snapshot payload

Files Changed:

  • flipt-client-go/client.go: Fixed streaming URL and response format to match Flipt v2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants