-
Notifications
You must be signed in to change notification settings - Fork 19
fix(engine-ffi): updated streaming endpoint URL #1314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @causton81 ! idk how we missed this! I must have tested with the now defunct Flipt Cloud which id use this format /internal/v1/evaluation/snapshots?[]namespaces={}
can you sign the DCO and assuming all tests pass we can merge and create a new release of all the sdks?
thank you again!
Signed-off-by: Chris Auston <[email protected]>
@causton81 thank for you for this contribution. Could you please sign the commit off and force pushed it to the branch so we could merge it? |
To add your Signed-off-by line to every commit in this branch:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1314 +/- ##
==========================================
- Coverage 80.36% 74.69% -5.67%
==========================================
Files 8 10 +2
Lines 4165 4415 +250
==========================================
- Hits 3347 3298 -49
- Misses 818 1117 +299 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@markphelps , I see |
@causton81 oh i think its an email mismatch, I'll just mark the DCO as accepted because you signed off anyways
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you !!!
@claude can you fix the streaming URL and response type for our Go client SDK ? similar to the fixes made in this PR? |
Claude finished @markphelps's task —— View job • Tasks
Changes Made:
Files Changed:
|
I needed this patch to get streaming to work with flipt v2.1.0.
Also needed flipt-io/flipt#4715