-
Notifications
You must be signed in to change notification settings - Fork 19
feat: add TLS configuration support to Go SDK #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1138 +/- ##
==========================================
- Coverage 80.36% 75.31% -5.05%
==========================================
Files 8 9 +1
Lines 4165 4477 +312
==========================================
+ Hits 3347 3372 +25
- Misses 818 1105 +287 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds TLS configuration support to the Go SDK, enabling secure HTTPS connections with custom certificate handling.
- Introduces a
WithTlsConfig
option for customtls.Config
- Updates tests and runner containers to use HTTPS and load CA certificates
- Expands README with TLS usage examples and bumps engine FFI version
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
test/main.go | Enabled HTTPS in test containers via useHTTPS and CA cert mounts |
flipt-engine-ffi/Cargo.toml | Bumped version to 0.11.0 |
flipt-client-go/config.go | Added WithTlsConfig option for custom TLS clients |
flipt-client-go/client_test.go | Test suite now reads CA certs and applies TLS config |
flipt-client-go/README.md | Added TLS Configuration section and examples |
Comments suppressed due to low confidence (2)
flipt-client-go/config.go:98
- Function name 'WithTlsConfig' should use consistent acronym casing, e.g. 'WithTLSConfig', to follow Go naming conventions for acronyms.
func WithTlsConfig(tlsConfig *tls.Config) Option {
flipt-client-go/README.md:128
- Update the documented option name to 'WithTLSConfig' to match the actual exported function name and maintain consistency.
- `WithTlsConfig`: The TLS configuration for connecting to servers with custom certificates. See [TLS Configuration](#tls-configuration).
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
…t-sdks into feat/go-tls * 'feat/go-tls' of https://github.com/flipt-io/flipt-client-sdks: Release flipt-client-ruby-v1.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Re: #1132
Like: #1137 , #1136 , #1135