Skip to content

Conversation

markphelps
Copy link
Contributor

Re: #1132

Like: #1137 , #1136 , #1135

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.31%. Comparing base (f701007) to head (3dfbdc5).
Report is 442 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1138      +/-   ##
==========================================
- Coverage   80.36%   75.31%   -5.05%     
==========================================
  Files           8        9       +1     
  Lines        4165     4477     +312     
==========================================
+ Hits         3347     3372      +25     
- Misses        818     1105     +287     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@markphelps markphelps marked this pull request as ready for review June 29, 2025 23:08
@markphelps markphelps requested a review from a team as a code owner June 29, 2025 23:08
@markphelps markphelps requested review from erka and Copilot June 29, 2025 23:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds TLS configuration support to the Go SDK, enabling secure HTTPS connections with custom certificate handling.

  • Introduces a WithTlsConfig option for custom tls.Config
  • Updates tests and runner containers to use HTTPS and load CA certificates
  • Expands README with TLS usage examples and bumps engine FFI version

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/main.go Enabled HTTPS in test containers via useHTTPS and CA cert mounts
flipt-engine-ffi/Cargo.toml Bumped version to 0.11.0
flipt-client-go/config.go Added WithTlsConfig option for custom TLS clients
flipt-client-go/client_test.go Test suite now reads CA certs and applies TLS config
flipt-client-go/README.md Added TLS Configuration section and examples
Comments suppressed due to low confidence (2)

flipt-client-go/config.go:98

  • Function name 'WithTlsConfig' should use consistent acronym casing, e.g. 'WithTLSConfig', to follow Go naming conventions for acronyms.
func WithTlsConfig(tlsConfig *tls.Config) Option {

flipt-client-go/README.md:128

  • Update the documented option name to 'WithTLSConfig' to match the actual exported function name and maintain consistency.
- `WithTlsConfig`: The TLS configuration for connecting to servers with custom certificates. See [TLS Configuration](#tls-configuration).

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jun 29, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jun 30, 2025
Signed-off-by: Mark Phelps <[email protected]>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jun 30, 2025
Copy link
Collaborator

@erka erka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@kodiakhq kodiakhq bot merged commit 6b66dc3 into main Jun 30, 2025
22 checks passed
@kodiakhq kodiakhq bot deleted the feat/go-tls branch June 30, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants