Skip to content

Conversation

markphelps
Copy link
Contributor

builds upon #1133 by implementing tls config in the Python SDK

@markphelps markphelps requested a review from a team as a code owner June 28, 2025 21:57
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 28, 2025
@markphelps markphelps requested review from erka and Copilot June 28, 2025 21:57
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces TLS support in the Python SDK while updating the container setup and test configurations to handle secure connections. Key changes include:

  • Enhancements to the Go-based test container setup for TLS, including dynamic port selection and architecture detection.
  • Addition of new TLS certificate files and scripts to generate them.
  • Updates to the Python client models, tests, and documentation to include a new TlsConfig structure.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/main.go Updated container configuration with TLS support and architecture logic.
test/fixtures/tls/* Added new TLS certificates and a certificate-generation script.
flipt-client-python/tests/test_flipt_client.py Enhanced tests to incorporate TLS configuration for the Python client.
flipt-client-python/flipt_client/models.py Introduced a new TlsConfig model for TLS settings in the client options.
flipt-client-python/README.md Updated documentation with details on TLS configuration usage.

@dosubot dosubot bot added the enhancement New feature or request label Jun 28, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.48%. Comparing base (f701007) to head (4be4299).
Report is 526 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1134      +/-   ##
==========================================
- Coverage   80.36%   75.48%   -4.88%     
==========================================
  Files           8        9       +1     
  Lines        4165     4467     +302     
==========================================
+ Hits         3347     3372      +25     
- Misses        818     1095     +277     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be ideal to generate the test certificates dynamically by running this script prior to executing other tasks, rather than committing them to version control. This could also be implemented in Go and we have in Flipt repo similar code. The fixture certificates are valid for one year, after which the tests will start failing unless they are renewed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i bumped them to expire in 10 years. id rather not introduce more potential for flakey tests by generating the certs on each run tbh

Base automatically changed from feat/issue-1132-self-signed-cert-support to main June 29, 2025 00:47
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jun 29, 2025
@markphelps markphelps force-pushed the feat/issue-1132-python-tls-support branch from 30fa92d to 4be4299 Compare June 29, 2025 15:09
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jun 29, 2025
@markphelps markphelps merged commit 4a485c1 into main Jun 29, 2025
34 checks passed
@markphelps markphelps deleted the feat/issue-1132-python-tls-support branch June 29, 2025 15:40
markphelps added a commit that referenced this pull request Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants