-
Notifications
You must be signed in to change notification settings - Fork 19
Feat: python tls support #1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: python tls support #1134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces TLS support in the Python SDK while updating the container setup and test configurations to handle secure connections. Key changes include:
- Enhancements to the Go-based test container setup for TLS, including dynamic port selection and architecture detection.
- Addition of new TLS certificate files and scripts to generate them.
- Updates to the Python client models, tests, and documentation to include a new TlsConfig structure.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
test/main.go | Updated container configuration with TLS support and architecture logic. |
test/fixtures/tls/* | Added new TLS certificates and a certificate-generation script. |
flipt-client-python/tests/test_flipt_client.py | Enhanced tests to incorporate TLS configuration for the Python client. |
flipt-client-python/flipt_client/models.py | Introduced a new TlsConfig model for TLS settings in the client options. |
flipt-client-python/README.md | Updated documentation with details on TLS configuration usage. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1134 +/- ##
==========================================
- Coverage 80.36% 75.48% -4.88%
==========================================
Files 8 9 +1
Lines 4165 4467 +302
==========================================
+ Hits 3347 3372 +25
- Misses 818 1095 +277 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
test/fixtures/tls/generate_certs.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be ideal to generate the test certificates dynamically by running this script prior to executing other tasks, rather than committing them to version control. This could also be implemented in Go and we have in Flipt repo similar code. The fixture certificates are valid for one year, after which the tests will start failing unless they are renewed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i bumped them to expire in 10 years. id rather not introduce more potential for flakey tests by generating the certs on each run tbh
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
30fa92d
to
4be4299
Compare
…ipt-client-sdks into feat/java-tls-config * 'feat/java-tls-config' of https://github.com/flipt-io/flipt-client-sdks: Feat: python tls support (#1134)
builds upon #1133 by implementing tls config in the Python SDK