Add the state machine of updating custom installation id in the local cache and update to Firebase Segmentation backend. #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cache and update to Firebase Segmentation backend. CL also contains unit tests. (The http client is not implemented yet.)
|
This is a pretty large PR, but the key part is just FirebaseSegmentation.java which needs a close review. |
|
/retest |
|
/retest |
vkryachko
reviewed
Jun 20, 2019
|
|
||
| Task<Void> setCustomInstallationId(String customInstallationId) { | ||
| return Tasks.forResult(null); | ||
| Task<Void> setCustomInstallationId(@Nullable String customInstallationId) { |
There was a problem hiding this comment.
should the return type be @NonNull public Task<Void> instead?
There was a problem hiding this comment.
Also what are the thread-safety/concurrency requirements for this method(including the ones it calls)? I looks like multiple calls to this from different threads could lead to races
There was a problem hiding this comment.
-
Yes, definitely it should be nonnull public
-
Change it to be synchronized
firebase-segmentation/src/main/java/com/google/firebase/segmentation/FirebaseSegmentation.java
Show resolved
Hide resolved
vkryachko
approved these changes
Jun 24, 2019
firebase-segmentation/src/main/java/com/google/firebase/segmentation/FirebaseSegmentation.java
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close review needed for FirebaseSegmentation.java
CL also contains unit tests.
The http client is not implemented yet.