LogFileManager.getLogString leaking Closeable during SessionReportingCoordinator.addLogsCustomKeysAndEventKeysToEvent

[Nek-12]

[READ] Step 1: Are you in the right place?

Issues filed here should be about bugs in the code in this repository. If you have a general
question, need help debugging, or fall into some other category use one of these other channels:

• For general technical questions, post a question on StackOverflow
  with the firebase tag.
• For general Firebase discussion, use the
  firebase-talk google group.
• For help troubleshooting your application that does not fall under one of the above categories,
  reach out to the personalized Firebase support channel.

[REQUIRED] Step 2: Describe your environment

• Android Studio version: N/A
• Firebase Component: Crashlytics
• Component version: 3.0.6

[REQUIRED] Step 3: Describe the problem

StrictMode policy violation: android.os.strictmode.LeakedClosableViolation: A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks.
                     	at android.os.StrictMode$AndroidCloseGuardReporter.report(StrictMode.java:2005)
                     	at dalvik.system.CloseGuard.warnIfOpen(CloseGuard.java:336)
                     	at java.io.RandomAccessFile.finalize(RandomAccessFile.java:1256)
                     	at java.lang.Daemons$FinalizerDaemon.doFinalize(Daemons.java:370)
                     	at java.lang.Daemons$FinalizerDaemon.processReference(Daemons.java:350)
                     	at java.lang.Daemons$FinalizerDaemon.runInternal(Daemons.java:322)
                     	at java.lang.Daemons$Daemon.run(Daemons.java:131)
                     	at java.lang.Thread.run(Thread.java:1012)
                     Caused by: java.lang.Throwable: Explicit termination method 'close' not called
                     	at dalvik.system.CloseGuard.openWithCallSite(CloseGuard.java:288)
                     	at dalvik.system.CloseGuard.open(CloseGuard.java:257)
                     	at java.io.RandomAccessFile.<init>(RandomAccessFile.java:310)
                     	at java.io.RandomAccessFile.<init>(RandomAccessFile.java:237)
                     	at com.google.firebase.crashlytics.internal.metadata.QueueFile.open(QueueFile.java:221)
                     	at com.google.firebase.crashlytics.internal.metadata.QueueFile.<init>(QueueFile.java:119)
                     	at com.google.firebase.crashlytics.internal.metadata.QueueFileLogStore.openLogFile(QueueFileLogStore.java:128)
                     	at com.google.firebase.crashlytics.internal.metadata.QueueFileLogStore.getLogBytes(QueueFileLogStore.java:79)
                     	at com.google.firebase.crashlytics.internal.metadata.QueueFileLogStore.getLogAsBytes(QueueFileLogStore.java:58)
                     	at com.google.firebase.crashlytics.internal.metadata.QueueFileLogStore.getLogAsString(QueueFileLogStore.java:69)
                     	at com.google.firebase.crashlytics.internal.metadata.LogFileManager.getLogString(LogFileManager.java:73)
                     	at com.google.firebase.crashlytics.internal.common.SessionReportingCoordinator.addLogsCustomKeysAndEventKeysToEvent(SessionReportingCoordinator.java:274)
                     	at com.google.firebase.crashlytics.internal.common.SessionReportingCoordinator.addLogsAndCustomKeysToEvent(SessionReportingCoordinator.java:306)
                     	at com.google.firebase.crashlytics.internal.common.SessionReportingCoordinator.persistRelevantAppExitInfoEvent(SessionReportingCoordinator.java:160)
                     	at com.google.firebase.crashlytics.internal.common.CrashlyticsController.writeApplicationExitInfoEventIfRelevant(CrashlyticsController.java:929)
                     	at com.google.firebase.crashlytics.internal.common.CrashlyticsController.doCloseSessions(CrashlyticsController.java:593)
                     	at com.google.firebase.crashlytics.internal.common.CrashlyticsController.finalizeSessions(CrashlyticsController.java:521)
                     	at com.google.firebase.crashlytics.internal.common.CrashlyticsCore.doBackgroundInitialization(CrashlyticsCore.java:250)
                     	at com.google.firebase.crashlytics.internal.common.CrashlyticsCore.lambda$doBackgroundInitializationAsync$0$com-google-firebase-crashlytics-internal-common-CrashlyticsCore(CrashlyticsCore.java:227)
                     	at com.google.firebase.crashlytics.internal.common.CrashlyticsCore$$ExternalSyntheticLambda0.run(D8$$SyntheticClass:0)
                     	at com.google.firebase.crashlytics.internal.concurrency.CrashlyticsWorker.lambda$submit$1(CrashlyticsWorker.java:96)
                     	at com.google.firebase.crashlytics.internal.concurrency.CrashlyticsWorker$$ExternalSyntheticLambda0.then(D8$$SyntheticClass:0)
                     	at com.google.android.gms.tasks.zze.run(com.google.android.gms:play-services-tasks@@18.1.0:1)
                     	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
                     	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
                     	at com.google.firebase.concurrent.CustomThreadFactory.lambda$newThread$0$com-google-firebase-concurrent-CustomThreadFactory(CustomThreadFactory.java:47)
                     	at com.google.firebase.concurrent.CustomThreadFactory$$ExternalSyntheticLambda0.run(D8$$SyntheticClass:0)
                     	at java.lang.Thread.run(Thread.java:1012) 
System.err           StrictMode VmPolicy violation with POLICY_DEATH; shutting down.

Steps to reproduce:

This seems to happen EITHER: on app startup after ANRs, leading to repeated anrs or crashes, or after setCustomKeys is called.

Relevant Code:

N/A - no user code in the stacktrace.

[lehcar09]

Hi @Nek-12, thank you for reaching out. I tried reproducing the issue, however, I did not encounter the error. I added a VM Policy below; are you using something similar?

     StrictMode.setVmPolicy(
            StrictMode.VmPolicy.Builder()
                .detectLeakedClosableObjects()
                .penaltyLog()
                .penaltyDeath()
                .build()
        )

Could you share the Firebase Crashlytics version you're using?

[Nek-12]

@lehcar09 where did you add the strict mode policy? You must add it in a content provider with higher than 2 000 000 000 priority to reproduce this.

You also need to have custom keys set and the app must have crashed prior to when you opened it for the test.

[Nek-12]

BTW i already shared the version I'm using.

[lehcar09]

I moved the strict mode policy in the ContentProvider from the Application class.

class MyContentProvider: ContentProvider() {
    override fun onCreate(): Boolean {
        StrictMode.setVmPolicy(
            StrictMode.VmPolicy.Builder()
                .detectLeakedClosableObjects()
                .penaltyLog()
                .penaltyDeath()
                .build()
        )
        return true
    }
}

AndroidManifest.xml

<provider android:name=".kotlin.MyContentProvider"
            android:authorities=".kotlin.MyContentProvider"
            android:exported="false"
            android:enabled="true"
            android:initOrder="2000000000"/>

I modified our Android quickstart app for Crashlytics, however I still wasn't able to encounter the issue. I'm using Firebase Crashlytics v20.0.1 and Crachlytics Gradle Plugin v3.0.6.

Am I doing it correct? Did I miss anything?

[Nek-12]

@lehcar09 Did you disable the original content provider of the firebase? You may try calling FirebaseApp.configure() manually to see if that just makes the problem more visible. Did you simulate a crash and then restart after that crash like I explained?

I also said customKeys should be set

[lehcar09]

Hi @Nek-12, I did disable the FirebaseInitProvider and initialize Firebase in the onCreate method of my own ContentProvider (as suggested in this Take Control of Your Firebase Init on Android blog post). As I mentioned, I modified our Android quickstart app for Crashlytics and it does set custom keys.

https://github.com/firebase/quickstart-android/blob/dbecdbb6ab4caabdbb074b442e3659eca34246ea/crash/app/src/main/java/com/google/samples/quickstart/crash/kotlin/MainActivity.kt#L42-L45

Are you constantly experiencing the issue?

Before I raise this to our engineer, aside from the Crashlytics Gradle plugin version (v3.0.6) you’ve shared, can you also share the Crashlytics SDK version you’re using (Please refer to this docs)? This is to ensure that you’re already using the latest version that includes the bug fixes and improvements.