Skip to content

Fix: Fixed issue with opening items from search results in Columns View #17657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Fixed issue with opening items from search results in Columns View #17657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44c365a
Fix: Fixed issue where open action not working for search results sta…
workbysaran Sep 19, 2025
cdea7e8
Fix: Enable handling of multiple item selection with Enter key in Det…
workbysaran Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 40 additions & 8 deletions src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,18 +458,29 @@ protected override async void FileList_PreviewKeyDown(object sender, KeyRoutedEv

if (ctrlPressed && !shiftPressed)
{
var folders = ParentShellPageInstance?.SlimContentPage.SelectedItems?.Where(file => file.PrimaryItemAttribute == StorageItemTypes.Folder);
if (folders is not null)
var folders = SelectedItems?.Where(file => file.PrimaryItemAttribute == StorageItemTypes.Folder);
if (folders?.Any() ?? false)
{
foreach (ListedItem folder in folders)
await NavigationHelpers.OpenPathInNewTab(folder.ItemPath);
}
}
else if (ctrlPressed && shiftPressed)
{
var selectedFolder = SelectedItems?.FirstOrDefault(item => item.PrimaryItemAttribute == StorageItemTypes.Folder);
if (selectedFolder is not null)
NavigationHelpers.OpenInSecondaryPane(ParentShellPageInstance, selectedFolder);
var selectedFolders = SelectedItems?.Where(item => item.PrimaryItemAttribute == StorageItemTypes.Folder);
if (selectedFolders?.Any() ?? false)
{
foreach (var selectedFolder in selectedFolders)
NavigationHelpers.OpenInSecondaryPane(ParentShellPageInstance, selectedFolder);
}
}
else if (!ctrlPressed && !shiftPressed && !UserSettingsService.FoldersSettingsService.OpenItemsWithOneClick)
{
if (SelectedItems?.Any() ?? false)
{
foreach (var selectedItem in SelectedItems)
await OpenItem(selectedItem);
}
}
}
else if (e.Key == VirtualKey.Enter && e.KeyStatus.IsMenuKeyDown)
Expand Down Expand Up @@ -607,12 +618,33 @@ clickedItem is Microsoft.UI.Xaml.Shapes.Rectangle
}
}

private async Task OpenItem(ListedItem item)
{
if (!Commands.OpenItem.IsExecutable)
{
var itemType = item.PrimaryItemAttribute == StorageItemTypes.Folder ? FilesystemItemType.Directory : FilesystemItemType.File;
await NavigationHelpers.OpenPath(item.ItemPath, ParentShellPageInstance, itemType);
}
else
{
await Commands.OpenItem.ExecuteAsync();
}
}

private async void FileList_DoubleTapped(object sender, DoubleTappedRoutedEventArgs e)
{
// Skip opening selected items if the double tap doesn't capture an item
if ((e.OriginalSource as FrameworkElement)?.DataContext is ListedItem item && !UserSettingsService.FoldersSettingsService.OpenItemsWithOneClick)
await Commands.OpenItem.ExecuteAsync();
else if ((e.OriginalSource as FrameworkElement)?.DataContext is not ListedItem && UserSettingsService.FoldersSettingsService.DoubleClickToGoUp)
var originalElement = e.OriginalSource as FrameworkElement;
var dataContext = originalElement?.DataContext;

// Try to get the item from DataContext or from sender (ListView)
ListedItem? item = dataContext as ListedItem;
if (item == null && sender is ListView listView && listView.SelectedItem is ListedItem selectedItem)
item = selectedItem;

if (item != null && !UserSettingsService.FoldersSettingsService.OpenItemsWithOneClick)
await OpenItem(item);
else if (item == null && UserSettingsService.FoldersSettingsService.DoubleClickToGoUp)
await Commands.NavigateUp.ExecuteAsync();

ResetRenameDoubleClick();
Expand Down
33 changes: 32 additions & 1 deletion src/Files.App/Views/Shells/ColumnShellPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using CommunityToolkit.WinUI;
using Microsoft.UI.Xaml;
using Microsoft.UI.Xaml.Controls;
using Microsoft.UI.Xaml.Media.Animation;
using Microsoft.UI.Xaml.Navigation;

namespace Files.App.Views.Shells
Expand Down Expand Up @@ -185,7 +186,37 @@ public override void NavigateToPath(string navigationPath, Type sourcePageType,
if (string.IsNullOrEmpty(navigationPath))
return;

this.FindAscendant<ColumnsLayoutPage>()?.SetSelectedPathOrNavigate(navigationPath, sourcePageType, navArgs);
var columnsLayoutPage = this.FindAscendant<ColumnsLayoutPage>();
if (columnsLayoutPage != null)
{
columnsLayoutPage.SetSelectedPathOrNavigate(navigationPath, sourcePageType, navArgs);
}
else
{
if (sourcePageType is null)
sourcePageType = InstanceViewModel.FolderSettings.GetLayoutType(navigationPath);

if (navArgs is not null && navArgs.AssociatedTabInstance is not null)
{
ItemDisplayFrame.Navigate(
sourcePageType,
navArgs,
new SuppressNavigationTransitionInfo());
}
else
{
var newNavArgs = new NavigationArguments()
{
NavPathParam = navigationPath,
AssociatedTabInstance = this
};

ItemDisplayFrame.Navigate(
sourcePageType,
newNavArgs,
new SuppressNavigationTransitionInfo());
}
}
}

public override void NavigateHome()
Expand Down
Loading