Skip to content

Misleading doc comment for use_network_action_output_cache #1055

@lf-

Description

@lf-

FYI this comment suggests that the behaviour believed in in #246 is the case.

/// Whether to consult the offline-cache buck-out dir for network action
/// outputs prior to running them. If no cached output exists, the action
/// (download_file, cas_artifact) will execute normally.
///
/// This supports fully-offline builds, where network actions like
/// download_file have an execution component that is inherently non-local (
/// e.g. making a HEAD request against the remote artifact to determine if
/// it needs to be downloaded again).
pub use_network_action_output_cache: bool,

It sounds from #246 that this comment is straight up not the intended use case, so I'm very confused what the setting is for. I indeed want the same thing as them which is that http_archives with a given hash survive daemon restarts.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions