Remove leftover indentation text nodes in DOM when elements are removed

[gastaldi]

• Fixes Maven.writeModel breaks some tests since v31 #129

[gastaldi]

@qmonmert b21fb24 (#130) looks like it doesn't mess up the final content

[gastaldi]

@qmonmert @murdos I believe I have fixed the issue you reported with this PR. Can any of you please give it a try and let me know?

[qmonmert]

can you publish a beta version to test in our project?

[murdos]

@qmonmert : I'll build a snapshot version locally and test it.

[murdos]

@gastaldi : it's a bit better, but there's still an extra line:

 <dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-dependencies</artifactId>
        <version>${spring-boot.version}</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>
      <dependency>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-dependencies</artifactId>
        <version>${spring-boot.version}</version>
        <scope>import</scope>
        
      </dependency>
    </dependencies>
  </dependencyManagement>

[gastaldi]

@murdos @qmonmert I added your test and a potential fix now, can you have another look, please?

[murdos]

@gastaldi : the issue mentioned above #130 (comment) is still present :/
I'll try to reproduce and provide a minimalist test case.

[murdos]

@gastaldi : the issue mentioned above #130 (comment) is still present :/ I'll try to reproduce and provide a minimalist test case.

@gastaldi : Here's the test modified to reproduce the issue:

    @Test
    void should_not_add_extra_line_break() throws Exception {
        Path pom = Paths.get(getClass().getResource("extra-line-pom.xml").toURI());
        Model model = Maven.readModel(pom);
        model.getDependencyManagement().getDependencies().remove(0);
        Dependency dep = new Dependency();
        dep.setGroupId("org.springframework.boot");
        dep.setArtifactId("spring-boot-dependencies");
        dep.setVersion("${spring-boot.version}");
        dep.setScope("import");
        dep.setType("pom");
        Dependency dep2 = new Dependency();
        dep2.setGroupId("org.springframework.boot");
        dep2.setArtifactId("spring-boot-dependencies");
        dep2.setVersion("${spring-boot.version}");
        dep2.setScope("import");
        model.getDependencyManagement().addDependency(dep2);
        StringWriter sw = new StringWriter();
        Maven.writeModel(model, sw);
        Approvals.verify(sw.toString());
    }

[gastaldi]

@murdos thank you for the test case, I've pushed a potential fix again, can you give it a try?

[murdos]

@gastaldi : I just tried, and it's now fixed! Thanks :-)

[gastaldi]

@murdos @qmonmert thank you very much for reporting and providing the test case. 35 should be on its way to central now, enjoy!

[qmonmert]

@gastaldi thanks to you 🙂