feat: extend the existingJavaTypes to support use of existing enumerations.

[k-wall]

Description

Fixes #7045

Extends the existing existingJavaTypes of the java-generator-maven-plugin' to allow the generated code to refer to existing enumerations.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Checklist

• Code contributed by me aligns with current project license: Apache 2.0
• I Added CHANGELOG entry regarding this change
• I have implemented unit tests to cover my changes
• I have added/updated the javadocs and other documentation accordingly
• No new bugs, code smells, etc. in SonarCloud report
• I tested my code in Kubernetes
• I tested my code in OpenShift

[andreaTP]

Thanks for this effort @k-wall !
Looks good apart from a single detail 🙂

[k-wall]

I don't think the test failure showing in CI relates to my chnage.

 Errors: 
Error:    JdkHttpLoggingInterceptorTest>AbstractHttpLoggingInterceptorTest.httpLargeResponseBodyLogged:205 » Execution java.net.ProtocolException: protocol error: Frame type(114) length(6776096) exceeds MAX_FRAME_SIZE(16384)
[INFO]

[andreaTP]

Errors in CI are spurious, thanks a lot for the effort, LGTM 👍

[k-wall]

Not sure if the Quality Gate being B means this cannot be merged. I looked at the issues being flagged by Sonar:

• java:S107 - constructor parameter count rule doesn't seem to be well adhered to by the project. In this case, there doesn't appear to be a reasonable alternative to adding the pkg parameter.
• java:S6355 - The project doesn't seem to use the Deprecated since/forRemoval parameters

the remaining issues relate to the new deprecated method.

I don't think there is anything to action. If the maintainers think different, I'll happily oblige.

[andreaTP]

I don't think there is anything to action.

Agreed.

[sonarqubecloud]

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[andreaTP]

Seems like there is some issues with the CI, @manusa this is ready to merge IMO.

[manusa]

Thx for the contribution, Keith.

Seems like there is some issues with the CI, @manusa this is ready to merge IMO.

I'm not sure if I'll be releasnig a 7.3.1 version tomorrow. Once that's clear I'll merge this one.

[k-wall]

I'm not sure if I'll be releasnig a 7.3.1 version tomorrow. Once that's clear I'll merge this one.

I see main is now versioned 7.4 and this PR is tagged for 7.4. It is mergeable now? Hoping to see it land before bit-rot sets in.

[manusa]

LGTM, thx!