-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[java-generator] Add native support for date-time fields #5279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
534ae02
to
26a282e
Compare
cc. @fabiobrz might be interested in reviewing 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @andreaTP ! I dropped a couple of questions and suggestions. Let me know what you think.
java-generator/core/src/main/java/io/fabric8/java/generator/nodes/AbstractJSONSchema2Pojo.java
Show resolved
Hide resolved
java-generator/core/src/main/java/io/fabric8/java/generator/nodes/JPrimitiveNameAndType.java
Show resolved
Hide resolved
thanks for the review @fabiobrz ! Ready for the next round! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments, @andreaTP.
Changes LGTM, approving. BTW - Feel free to squash your last commit ("review").
4404d04
to
22517d7
Compare
Squashed and ready 👍 |
22517d7
to
33bf750
Compare
Kudos, SonarCloud Quality Gate passed! |
Description
This PR adds native support for
date-time
format of fields of typestring
.Please note that this is a breaking change, we should at least bump the minor version to introduce it.
date-time
native parsing is very useful, especially in the standardConditions
in theStatus
stanza (e.g. https://maelvls.dev/kubernetes-conditions/lastTransitionTime
).Type of change
test, version modification, documentation, etc.)
Checklist