Skip to content

Conversation

andreaTP
Copy link
Member

@andreaTP andreaTP commented Jun 23, 2023

Description

This PR adds native support for date-time format of fields of type string.
Please note that this is a breaking change, we should at least bump the minor version to introduce it.

date-time native parsing is very useful, especially in the standard Conditions in the Status stanza (e.g. https://maelvls.dev/kubernetes-conditions/ lastTransitionTime).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@andreaTP
Copy link
Member Author

cc. @fabiobrz might be interested in reviewing 🙂

Copy link
Contributor

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @andreaTP ! I dropped a couple of questions and suggestions. Let me know what you think.

@andreaTP
Copy link
Member Author

andreaTP commented Jul 3, 2023

thanks for the review @fabiobrz ! Ready for the next round!

Copy link
Contributor

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments, @andreaTP.
Changes LGTM, approving. BTW - Feel free to squash your last commit ("review").

@andreaTP andreaTP force-pushed the breaking-date-time branch from 4404d04 to 22517d7 Compare July 4, 2023 10:34
@andreaTP
Copy link
Member Author

andreaTP commented Jul 4, 2023

Squashed and ready 👍

@manusa manusa force-pushed the breaking-date-time branch from 22517d7 to 33bf750 Compare July 10, 2023 11:38
@manusa manusa added this to the 6.8.0 milestone Jul 10, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit a7c630b into fabric8io:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants