Skip to content

[java-generator] - Gradle plugin #5090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 29, 2023
Merged

[java-generator] - Gradle plugin #5090

merged 4 commits into from
May 29, 2023

Conversation

fabiobrz
Copy link
Contributor

@fabiobrz fabiobrz commented May 2, 2023 •
edited
Loading

Description

Adding a basic implementation for a Java Generator Gradle plugin

FYI @andreaTP

Fix #4829

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@fabiobrz fabiobrz force-pushed the java-gen.gradle-plugin branch from 7e699e2 to 85695dd Compare May 2, 2023 09:24
andreaTP
andreaTP reviewed May 2, 2023
View reviewed changes
Copy link
Member

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding work @fabiobrz , thanks a ton!
Even an integration test! ❤️

I added a few questions/notes, especially due to my inexperience with Gradle plugins.
I think that @manusa input would be helpful here 🙂

andreaTP
andreaTP reviewed May 2, 2023
View reviewed changes
@fabiobrz fabiobrz force-pushed the java-gen.gradle-plugin branch 2 times, most recently from 6273aa7 to 8e65f8e Compare May 4, 2023 16:23
andreaTP
andreaTP reviewed May 8, 2023
View reviewed changes
andreaTP
andreaTP requested changes May 8, 2023
View reviewed changes
Copy link
Member

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A last round of minor comments and is good to go! Thanks again @fabiobrz !

@fabiobrz fabiobrz force-pushed the java-gen.gradle-plugin branch 4 times, most recently from 7970d58 to bb51a07 Compare May 10, 2023 11:15
@fabiobrz fabiobrz force-pushed the java-gen.gradle-plugin branch from bb51a07 to 0f70512 Compare May 10, 2023 11:15
@fabiobrz fabiobrz marked this pull request as ready for review May 10, 2023 11:15
@fabiobrz
Copy link
Contributor Author

Hi @andreaTP - I added one unit test, at least for the plugin class itself, and some documentation. I hope I addressed all the concerns you pointed out. Marking the PR as ready.

Feel free to let me know in case you have additional thoughts.

@fabiobrz fabiobrz closed this May 13, 2023
@fabiobrz fabiobrz reopened this May 13, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

5.0% 5.0% Coverage
0.0% 0.0% Duplication

andreaTP
andreaTP approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work LGTM, thanks a lot @fabiobrz !

@andreaTP andreaTP added this to the 6.7.0 milestone May 22, 2023
manusa
manusa approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

manusa
manusa approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 9ef5201 into fabric8io:master May 29, 2023
@EricWittmann EricWittmann mentioned this pull request Jul 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@andreaTP andreaTP andreaTP approved these changes

@oscerd oscerd Awaiting requested review from oscerd

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia

@shawkins shawkins Awaiting requested review from shawkins

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
component/java-generator
Projects
None yet
Milestone
6.7.0
Development

Successfully merging this pull request may close these issues.

Gradle Plugin for Java Generation from CRD
3 participants
@fabiobrz @manusa @andreaTP