OSIO production API urls hardcoded in the code

[vpavlin]

There are API urls hardcoded in this repository:

https://github.com/fabric8io/fabric8-pipeline-library/blob/master/vars/deployOpenShiftSnapshot.groovy#L57-L61

@jstrachan mentioned this file is not really used when someone uses fabric8-pipeline-library, which is good.

It would be great if you could use more descriptive name for the file mentioned above - something like deployOSIOProdSnapshot.yaml maybe?

And/or (when there is time) take the hardcoded values out to some config, in case the groovy script has a potential to be used for other deployments or by other people.

[rawlingsj]

The approach would be to move the env vars out of the reusable pipeline just as we've done on a similar function https://github.com/fabric8io/fabric8-pipeline-library/blob/master/vars/deployKubernetesSnapshot.groovy#L99-L108 they are instead passed as a map from the Jenkinsfile of the repo that's being run, for example:
https://github.com/fabric8io/openshift-jenkins-s2i-config/blob/master/Jenkinsfile#L146-L148

[vpavlin]

Is there a way to figure out which Jenkinsfiles use these values? I.e. what breaks if we remove it from library and where they need to be placed?

[rawlingsj]

At the moment there's only two repos that deploy snapshot builds so updating them should do it:

• fabric8-ui
• fabric8-planner