-
Notifications
You must be signed in to change notification settings - Fork 27
Update slurm tests returned perf_values #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@jgphpc the tests are passing on Daint, but are you addressing the gres issue reported on SD-66684? It is unclear, as the old test (which you are deleting in this PR) still fails and the updated one (SlurmGPUGresTest) doesn't. |
|
ok now I found the SlurmGPUGresTest (I was looking at the wrong gres test), but my question remains: all tests in this PR pass now on daint, while the old gres_gpu.py fails. Which is odd if this PR is not addressing SD-66684, but it could be me running it wrong? |
// int chunk = 33554432; // 32M | ||
// int chunk = 67108864; // 64M | ||
// int chunk = 134217728; // 128M | ||
int chunk = 134217728; // 128M |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe leave a comment to document why you are changing this?
UENV=prgenv-gnu/25.06:rc5 ./R -c cscs-reframe-tests.git/checks/system/slurm/slurm.py -J p=normal -r
cscs-ci run alps-daint-uenv
comment in the Pull Requestcscs-ci run alps-daint-uenv;MY_UENV=cp2k/2025.1:v2