Skip to content

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Sep 8, 2025

Required to bump to Go 1.25.1. Follow up on #19692/#19751/#19712.

Link to #20602.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ivanvc
Copy link
Member Author

ivanvc commented Sep 8, 2025

/test pull-etcd-verify

@ivanvc ivanvc force-pushed the bump-golangci-lint-to-v2 branch from ad812aa to af9240d Compare September 8, 2025 04:46
@ivanvc
Copy link
Member Author

ivanvc commented Sep 8, 2025

/test pull-etcd-verify

@ivanvc ivanvc force-pushed the bump-golangci-lint-to-v2 branch from af9240d to 02e75d5 Compare September 8, 2025 05:06
@ivanvc ivanvc marked this pull request as ready for review September 8, 2025 05:07
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.11%. Comparing base (d46722b) to head (c2a53f7).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

see 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20620      +/-   ##
==========================================
- Coverage   69.22%   69.11%   -0.12%     
==========================================
  Files         420      420              
  Lines       34780    34780              
==========================================
- Hits        24078    24038      -40     
- Misses       9309     9340      +31     
- Partials     1393     1402       +9     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d46722b...c2a53f7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ivanvc ivanvc force-pushed the bump-golangci-lint-to-v2 branch from 02e75d5 to d0fb807 Compare September 8, 2025 05:34
@ahrtr
Copy link
Member

ahrtr commented Sep 8, 2025

@ivanvc please rebase this PR, thx

@ivanvc ivanvc force-pushed the bump-golangci-lint-to-v2 branch from d0fb807 to c2a53f7 Compare September 8, 2025 17:26
@ivanvc
Copy link
Member Author

ivanvc commented Sep 8, 2025

/cc @ahrtr

@k8s-ci-robot k8s-ci-robot requested a review from ahrtr September 8, 2025 18:26
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 532ffdb into etcd-io:main Sep 8, 2025
31 checks passed
@ivanvc ivanvc deleted the bump-golangci-lint-to-v2 branch September 8, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants