[release-3.6] Update release script to exactly match the target tag #19951
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@joshjms will followup this, thx |
|
To be clearer, the command below returned 64, so it's greater than 0 |
ahrtr
force-pushed
the
release_script_20250515
branch
from
888b65e to
6ff112e
Compare
Signed-off-by: Benjamin Wang <[email protected]>
ahrtr
force-pushed
the
release_script_20250515
branch
from
6ff112e to
a1bcdc7
Compare
|
/cherrypick release-3.4 |
|
@joshjms: new pull request created: #19953 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release-3.5 |
|
@joshjms: new pull request created: #19954 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick main |
|
@joshjms: new pull request created: #19955 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
When we release etcd v3.6.0, we ran into an issue. The command
git tag --list | grep -c "${RELEASE_VERSION}")" -gt 0returned 64, so it thought the tag v3.6.0 already existed, but actually not.So updating the script to exactly match the target tag.
Normally we fix in main, and backport to stable releases, given the tight schedule, so we fix it release-3.6 for now, and backport and forward port to other branches.