breaking(Transition): Only call findDOMNode if necessary #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
changed the title
eps1lon
added a commit
that referenced
this pull request
Jun 19, 2019
* feat(Transition): Add findDOMNode prop Useful for strict mode compatibility. * test(Transition): Add test case for default findDOMNode * test(Transition): Use jest.fn instead of sinon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking reactjs#468
Breaking
Callbacks that use argument spread or access
argumentswill not have acces to the DOM node. The DOM node is only passed if Function.prototype.length is greater than 0.The first callback enables strict mode compatible usage of
Transition. If you expect the node in callbacks a call tofindDOMNodeis required which issues a warning inReact.StrictMode.