Docker: use a entrypoint script #1227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleisauke
force-pushed
the
docker-entrypoint
branch
from
96453c5 to
3d65b06
Compare
kleisauke
changed the title
kleisauke
force-pushed
the
docker-entrypoint
branch
from
04842b1 to
94b535a
Compare
|
Ah, I forgot that this would break extended Docker images, for example: FROM emscripten/emsdk:3.1.40
RUN embuilder build zlib$ docker build -t test .
STEP 1/2: FROM emscripten/emsdk:3.1.40
STEP 2/2: RUN embuilder build zlib
/bin/sh: 1: embuilder: not found
Error: building at STEP "RUN embuilder build zlib": while running runtime: exit status 127 |
|
Maybe still worth landing this, but while preserving the PATH with a comment? |
kleisauke
force-pushed
the
docker-entrypoint
branch
from
de0fb21 to
4c03d6f
Compare
|
Can you rebase this change? (assuming we still want to land it?) |
In favor of `/etc/bash.bashrc`, which is only read for interactive shells.
kleisauke
force-pushed
the
docker-entrypoint
branch
from
4c03d6f to
ee49446
Compare
|
Just rebased, sorry for the delay. |
sbc100
approved these changes
Jul 6, 2023
shlomif
pushed a commit
to shlomif/emsdk
that referenced
this pull request
Sep 29, 2023
In favor of `/etc/bash.bashrc`, which is only read for interactive shells.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In favor of
/etc/bash.bashrc, which is only read for interactive shells.