Add a check in cache.erase() to never attempt it in FROZEN_CACHE mode. #25259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Sep 11, 2025
tools/cache.py
Outdated
| @@ -83,6 +83,9 @@ def ensure(): | |||
|
|
|||
| def erase(): | |||
| ensure_setup() | |||
| if config.FROZEN_CACHE: | |||
| raise Exception('Cache cannot be erased when FROZEN_CACHE is set') | |||
There was a problem hiding this comment.
assert not config.FROZEN_CACHE, 'Cache cannot be erased when FROZEN_CACHE is set'
sbc100
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If external logic is correct, then this exception should never be thrown.
(I considered no-opping this call in FROZEN_CACHE mode, but I think that is not a good idea. Better to fix any callers to cache.erase() in FROZEN_CACHE mode directly)