Allow only specifying guideline condition or action when updating gui… #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kichanyurd
reviewed
Jan 16, 2025
src/parlant/bin/client.py
Outdated
| @@ -2468,6 +2476,8 @@ def guideline_update( | |||
| check: bool, | |||
| connect: bool, | |||
| ) -> None: | |||
| assert condition or action | |||
There was a problem hiding this comment.
This isn't a good way to do it. If someone runs it with neither --action or --condition, instead of getting a clear error message that at least one is required, they will get an assertion error.
mc-dorzo
force-pushed
the
feature/mc-516-allow-only-specifying-guideline-condition-or-action-when
branch
from
ee68cfb to
58ebb69
Compare
mc-dorzo
deleted the
feature/mc-516-allow-only-specifying-guideline-condition-or-action-when
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…deline from CLI