Skip to content

Add support for "Move to file" interactive code action #4866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for "Move to file" interactive code action #4866

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94e3fcf
lsp-javascript: add support for "Move to file" code action
guillaumebrunerie Aug 30, 2025
bf0c6bb
Use lsp-get and lsp-put
guillaumebrunerie Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions clients/lsp-javascript.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,6 +824,15 @@ to run the command in."
(lsp-clients-typescript-require-resolve (f-parent (lsp-package-path 'typescript)))
(lsp-package-path 'typescript))))

(lsp-defun lsp-clients-typescript-handle-interactive-actions ((&Command :arguments? [args]))
(pcase (gethash "action" args)
("Move to file"
(let* ((directory (file-name-directory (buffer-file-name)))
(target-file-name (expand-file-name (read-file-name "Destination file: " directory))))
(puthash "interactiveRefactorArguments"
`((targetFile . ,target-file-name))
args)))))

(lsp-register-client
(make-lsp-client :new-connection (lsp-stdio-connection (lambda ()
`(,(lsp-package-path 'typescript-language-server)
Expand All @@ -845,6 +854,7 @@ to run the command in."
(list :plugins lsp-clients-typescript-plugins))
(when lsp-clients-typescript-preferences
(list :preferences lsp-clients-typescript-preferences))
(list :supportsMoveToFileCodeAction t)
`(:tsserver ( :path ,(lsp-clients-typescript-server-path)
,@lsp-clients-typescript-tsserver))))
:initialized-fn (lambda (workspace)
Expand All @@ -858,6 +868,7 @@ to run the command in."
(format-enable (or lsp-javascript-format-enable lsp-typescript-format-enable)))
(lsp:set-server-capabilities-document-formatting-provider? caps format-enable)
(lsp:set-server-capabilities-document-range-formatting-provider? caps format-enable)))
:action-filter 'lsp-clients-typescript-handle-interactive-actions
:ignore-messages '("readFile .*? requested by TypeScript but content not available")
:server-id 'ts-ls
:request-handlers (ht ("_typescript.rename" #'lsp-javascript--rename))
Expand Down
Loading