-
Notifications
You must be signed in to change notification settings - Fork 389
Implement MSC4169: backwards-compatible redaction sending for rooms < v11 using the /send endpoint #18898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MSC4169: backwards-compatible redaction sending for rooms < v11 using the /send endpoint #18898
Conversation
While there is a dedicated API endpoint for redactions, being able to send redactions using the normal send endpoint is useful when using MSC-4140 for sending delayed redactions to replicate expiring messages. Currently this would only work on rooms >= v11 but fail with an internal server error on older room versions.
522e941
to
4964d32
Compare
I just remembered I made matrix-org/matrix-spec-proposals#4169 which is basically this, so we should add a Test failures here look like flakes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Implement MSC4169
While there is a dedicated API endpoint for redactions, being able to send redactions using the normal send endpoint is useful when using MSC4140 for sending delayed redactions to replicate expiring messages. Currently this would only work on rooms >= v11 but fail with an internal server error on older room versions when setting the
redacts
field in the content, since older rooms would require that field to be outside ofcontent
. We can address this by copying it over if necessary.Relevant spec at https://spec.matrix.org/v1.8/rooms/v11/#moving-the-redacts-property-of-mroomredaction-events-to-a-content-property
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.