-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat: Disable session lock when running in element-desktop #30643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane, but it'd be cleaner if this was done via the Platform abstractions, i.e by only calling the lock check/get code from WebPlatform, then ElectronPlatform would not even be calling it
Could you resolve your conflicts so CI can run |
Seems to have broken a bunch of tests - will have to prod after im back from hols. |
@t3chguy wondering if you could help shed some light on the test failures? I'm trying to debug locally, but there's so much noise from other random failures, I'm finding it really difficult to actually work out what's going wrong. |
You'd probably want to debug the jest tests locally, my guess is something is getting stubbed/mocked out and thus the lockout isn't working as expected |
Ah, I think it's because a |
b2973b6
to
b328ad0
Compare
b328ad0
to
5e5a250
Compare
Slightly broke the branch by merging in my encrypted state stuff, should be fixed now. |
@kaylendog still looks like a couple of tests are unhappy |
Yep, working on locally.. |
bc10e3e
to
baffeea
Compare
Should be good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Bypasses
checkSessionLockFree
andgetSessionLock
if we detect we are running inelement-desktop
(i.e.window.electron
is defined).Checklist
public
/exported
symbols have accurate TSDoc documentation.