Skip to content

Conversation

langleyd
Copy link
Member

@langleyd langleyd commented Aug 28, 2025

This PR forces on the new room list for app/develop and fixes the tests that used to depend on the old room list

  • Fixes for axe have been split out into a separate PR.
  • There are 2 fixes still contained in this PR that are awkward to split out:
    • A fix to LandmarkNavigation that needs to change when the new room list changes as the selectors have changed. There is an accompanying fix to the RoomListPanel.
    • A fix to RoomListStoreV3. Rooms were not being remove from the new room list when a user cancelled their own knocking request, I think we should be using the "Effective" membership events to account for this.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Keep legacy viewRoomByName until we delete the olds tests.
@dbkr dbkr added this pull request to the merge queue Sep 15, 2025
github-merge-queue bot pushed a commit that referenced this pull request Sep 15, 2025
* Default to new room list and enforce in config for app and develop

* Update jest tests

* Update LandmarkNavigation and e2e test

* Update viewRoomByName helper

* lint

* Update Add -> New Room flow

Keep legacy viewRoomByName until we delete the olds tests.

* Update e2e test to use Add -> Start Chat

* Update screenshots

* Fix viewRoomByName, can't use option as it contains more that just the room name. Using title which should be exact.

* Fix knocking tests

* fix layout.spec.ts and pstn.spec

* timeline snapshots

* Fix spotlight.spec

* TAC spaces and media preview settings

* Fix more screenshots and mark as unread tests

* Fix leftpanel test

* Bugfix for knocking use case. We should check EffectiveMembership when remove rooms from the new room list, so that knocking is handled

* Fix openCreateRoomDialog to new room list specifics to fix create-knock-room.spec.ts

* lint

* Fix Landmark navigation from left panel search to the next landmark

* lint

* Update window-12px-linux.png

* Update apps-drawer-linux.png

* Update sliding sync e2e tests

* Update some screenshots

* Revert change to the space create screenshot

* Use actual screenshot

as focused elements are different when generated locally

* Fix test selectors

* Morfe test screenshot selector / update

* Add test for landmark navigation

* Replace screenshots

* Fix another test that just got added an hour ago

* Not sure why this was changed, doesn't seem necessary

* Disambiguate selector

* Another screenshot that's now changed in width by 1px

* Revert changes to config files

It's being turned on by default so these are unnecessary

* Convert read.unread assertions to new room list

removing support for checking for activity in assertUnread which was
unused.

* Update room list order tests

that feel a bit like they ought to be in room-list rather than read-receipts but whatever

---------

Co-authored-by: David Baker <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 15, 2025
@dbkr dbkr added this pull request to the merge queue Sep 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 15, 2025
@dbkr dbkr added this pull request to the merge queue Sep 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 15, 2025
@dbkr dbkr added this pull request to the merge queue Sep 16, 2025
Merged via the queue into develop with commit 3432613 Sep 16, 2025
35 checks passed
@dbkr dbkr deleted the langleyd/enable_new_room_list branch September 16, 2025 08:29
@vcunat
Copy link

vcunat commented Sep 23, 2025

You say "by default", but is there a way to remain on the old room list? For my usage I find this (v1.12.0) a significant UX downgrade, even after looking through settings a lot, trying to mitigate it somehow.

@t3chguy
Copy link
Member

t3chguy commented Sep 23, 2025

@vcunat you can disable it in Settings > Labs only if your instance has show_labs_settings: true in config.json, or it can also be disabled in config.json features field.

@herndlm
Copy link

herndlm commented Sep 23, 2025

You say "by default", but is there a way to remain on the old room list? For my usage I find this (v1.12.0) a significant UX downgrade, even after looking through settings a lot, trying to mitigate it somehow.

I think for me one of the filters (Unreads/People/Rooms) was suddenly selected by default and me never using it, I didn't realize that I can just unselect them and it confused me massively. after toggling beta settings they were unchecked though. anyway, maybe you experience something similar?

@vcunat
Copy link

vcunat commented Sep 23, 2025

I only see "Video rooms" and "Notification Settings" in the labs.

@t3chguy
Copy link
Member

t3chguy commented Sep 23, 2025

@vcunat sounds like your instance lacks this:

only if your instance has show_labs_settings: true in config.json

image

There are many options available in labs with that option enabled.

@vcunat
Copy link

vcunat commented Sep 23, 2025

My instance, as in https://app.element.io or matrix.org?

Anyway, my "problem" is that there are veeery many rooms. So I was permanently in a room view (icons only on the left) where I had the "favorite" rooms first and underneath the normal rooms from which only a couple last-active could fit – and the rest would get visible by simple scrolling. Now I'd apparently have to expand the filter list and adjust filters whenever I wanted to have a look.

Also the room list takes a few times more width than before. It can't be reduced to just icons anymore, which hurts me especially when viewing threads. Well sure, I could start maximizing the Element window whenever I do something like that...

@t3chguy
Copy link
Member

t3chguy commented Sep 23, 2025

app.element.io, matrix.org is your (presumably) chosen Matrix homeserver.

As you can see on http://app.element.io/config.json show_labs_settings is false

@bertiebaggio
Copy link

bertiebaggio commented Sep 23, 2025

@vcunat It can still be disabled for now on app.element.io if devtools are enabled (/devtools command in any room)

@JohnDepon
Copy link

You say "by default", but is there a way to remain on the old room list? For my usage I find this (v1.12.0) a significant UX downgrade, even after looking through settings a lot, trying to mitigate it somehow.

I agree, the new room list is a major downgrade in terms of usability. It might look cleaner, but it removes significant functionality. You can no longer have in one screen/view the 3 groups (Favorites/People/Rooms) you had before (without having to click anywhere to see the stuff you want), with the option to show more/less rooms for each group and also can no longer show message previews.

I've disabled the new room list for now, but I am afraid this option will be removed in the future, making Element unusable for me.

@t3chguy
Copy link
Member

t3chguy commented Sep 23, 2025

and also can no longer show message previews.

This isn't true...

image image

@bertiebaggio
Copy link

@JohnDepon There is a just-opened issue for groups/sections instead of filters you might be interested in

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Sep 23, 2025
https://build.opensuse.org/request/show/1306767
by user dheidler + anag_factory
- Version 1.12.0
  ## 🦖 Deprecations
  * Remove remaining support for outdated .well-known settings (element-hq/element-web#30702). Contributed by @richvdh.
  ## ✨ Features
  * Add decline button to call notification toast (use new notification event) (element-hq/element-web#30729). Contributed by @toger5.
  * Use the new room list by default (element-hq/element-web#30640). Contributed by @langleyd.
  * "Verify this device" redesign (element-hq/element-web#30596). Contributed by @uhoreg.
  * Set Element Call "intents" when starting and answering DM calls. (element-hq/element-web#30730). Contributed by @Half-Shot.
  * Add axe compliance for new room list (https://github.com
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Sep 23, 2025
https://build.opensuse.org/request/show/1306768
by user dheidler + anag_factory
- Fix fix-oxc-resolver.patch
- Version 1.12.0
  ## 🦖 Deprecations
  * Remove remaining support for outdated .well-known settings (element-hq/element-web#30702). Contributed by @richvdh.
  ## ✨ Features
  * Automatically select first source for desktop capture under Wayland (element-hq/element-desktop#2526). Contributed by @byquanton.
  * Add decline button to call notification toast (use new notification event) (element-hq/element-web#30729). Contributed by @toger5.
  * Use the new room list by default (element-hq/element-web#30640). Contributed by @langleyd.
  * "Verify this device" redesign (element-hq/element-web#30596). Contributed by @uhoreg.
  * Set Element Call "int
@soonic6
Copy link

soonic6 commented Sep 24, 2025

is the option gone, to hide the "room name"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants