-
Notifications
You must be signed in to change notification settings - Fork 38
Upgrade upstream open-telemetry components to v0.130.0 #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Vishal Raj <[email protected]>
Signed-off-by: Vishal Raj <[email protected]>
httpClientConfig.Auth = &configauth.Config{ | ||
httpClientConfig.Auth = configoptional.Some(configauth.Config{ | ||
AuthenticatorID: component.NewID(metadata.Type), | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[For reviewers] Highlighted changes: configoptional
adaptation
// TODO: Remove this once we have a proper way to configure TLS | ||
defaultServerConfig.TLS = nil | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -54,7 +54,6 @@ func createDefaultConfig() component.Config { | |||
defaultElasticSearchClient := configelasticsearch.NewDefaultClientConfig() | |||
httpCfg := confighttp.NewDefaultServerConfig() | |||
httpCfg.Endpoint = "localhost:4320" | |||
httpCfg.TLS = nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved from infraobs side
After elastic#663 there are still some OTel libraries on v0.129.0. This bumps them all to v0.130.0 for consistency.
No description provided.