Skip to content

Conversation

lahsivjar
Copy link
Contributor

No description provided.

@lahsivjar lahsivjar requested review from a team as code owners July 15, 2025 13:39
@lahsivjar lahsivjar requested review from SylvainJuge and gizas July 15, 2025 13:39
Comment on lines -44 to -46
httpClientConfig.Auth = &configauth.Config{
httpClientConfig.Auth = configoptional.Some(configauth.Config{
AuthenticatorID: component.NewID(metadata.Type),
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[For reviewers] Highlighted changes: configoptional adaptation

Comment on lines -60 to -62
// TODO: Remove this once we have a proper way to configure TLS
defaultServerConfig.TLS = nil

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[For reviewers] Highlighted changes: configoptional adaptation (the zero value of configoptional, as per the docs, in None, ref)

@@ -54,7 +54,6 @@ func createDefaultConfig() component.Config {
defaultElasticSearchClient := configelasticsearch.NewDefaultClientConfig()
httpCfg := confighttp.NewDefaultServerConfig()
httpCfg.Endpoint = "localhost:4320"
httpCfg.TLS = nil
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[For reviewers] Highlighted changes: configoptional adaptation (the zero value of configoptional, as per the docs, in None, ref)

Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from infraobs side

@lahsivjar lahsivjar enabled auto-merge (squash) July 15, 2025 14:38
@lahsivjar lahsivjar merged commit f037dbd into elastic:main Jul 15, 2025
13 checks passed
@lahsivjar lahsivjar deleted the update-otelcol-v130 branch July 15, 2025 14:48
andrzej-stencel added a commit to andrzej-stencel/opentelemetry-collector-components that referenced this pull request Jul 16, 2025
After elastic#663 there are still some OTel libraries on v0.129.0.
This bumps them all to v0.130.0 for consistency.
andrzej-stencel added a commit that referenced this pull request Jul 23, 2025
After #663 there are still some OTel libraries on v0.129.0.
This bumps them all to v0.130.0 for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants