Skip to content

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Sep 12, 2025

Proposed commit message

Disable dynamic mappings for beyondinsight_password_safe.* to prevent
unknown fields from receiving automatic mappings. This approach ensures
that API changes introducing new fields can be handled safely with
explicit field mappings and minimal risk of breaking existing users.

Standardize pipeline structures across all data streams with consistent
processing order:

- ecs.version
- terminate
- json decoding
- drop null/empty
- convert numberic IDs to strings
- convert camel-case to snake-case
- timestamps
- general ECS mappings
- append to ECS related.* fields

Sort fields.yml files alphabetically by name.

Remove unused package-level _dev/deploy. Each data stream has its own
mock test config.

BREAKING: The dsskey_rule_id field was renamed to dss_key_rule_id in
the managedsystem data stream to follow the snake-case naming pattern.

Related: #14985

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

…namic mappings

Disable dynamic mappings for beyondinsight_password_safe.* to prevent
unknown fields from receiving automatic mappings. This approach ensures
that API changes introducing new fields can be handled safely with
explicit field mappings and minimal risk of breaking existing users.

Standardize pipeline structures across all data streams with consistent
processing order:

- ecs.version
- terminate
- json decoding
- drop null/empty
- convert numberic IDs to strings
- convert camel-case to snake-case
- timestamps
- general ECS mappings
- append to ECS related.* fields

Sort fields.yml files alphabetically by name.

Remove unused package-level _dev/deploy. Each data stream has its own
mock test config.

BREAKING: The dsskey_rule_id field was renamed to dss_key_rule_id in
the managedsystem data stream to follow the snake-case naming pattern.

Related: elastic#14985
[git-generate]
cd packages/beyondinsight_password_safe
elastic-package test pipeline -g
elastic-package test system -g
elastic-package build
@andrewkroh andrewkroh force-pushed the feat/beyondinsight_password_safe/pipeline-cleanup branch from 2f78058 to 273149d Compare September 12, 2025 15:28
@andrewkroh andrewkroh added enhancement New feature or request breaking change Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:beyondinsight_password_safe BeyondInsight and Password Safe labels Sep 12, 2025
@andrewkroh andrewkroh marked this pull request as ready for review September 12, 2025 15:32
@andrewkroh andrewkroh requested a review from a team as a code owner September 12, 2025 15:32
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

Copy link

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:beyondinsight_password_safe BeyondInsight and Password Safe Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants