Refactor property and attribute mapping tests #2337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
reviewed
Oct 25, 2016
| protected abstract object ExpectJson { get; } | ||
|
|
||
| protected virtual object ExpectJsonFluentOnly { get; } | ||
| public TypeMappingTestBase(WritableCluster cluster, EndpointUsage usage) : base(cluster, usage) { } |
|
LGTM |
russcam
approved these changes
Oct 25, 2016
Our property mapping tests weren't sufficient as they only tested serilization of fluent syntax and attribute types. This commit adds new tests that test both the fluent and initializer types, and run them as integration tests as well so we can validate our properties against ES. Also tackled #2322 as part of this, as I did a full pass over all of our datatype mappings. Code review changes and rename of base test classes Change DynamicMapping to Union<bool, DynamicMapping>
gmarz
force-pushed
the
fix/mapping-tests
branch
from
ee62df7 to
7b5eb01
Compare
This was referenced Oct 25, 2016
gmarz
added a commit
that referenced
this pull request
Oct 25, 2016
Our property mapping tests weren't sufficient as they only tested serilization of fluent syntax and attribute types. This commit adds new tests that test both the fluent and initializer types, and run them as integration tests as well so we can validate our properties against ES. Also tackled #2322 as part of this, as I did a full pass over all of our datatype mappings. Code review changes and rename of base test classes Change DynamicMapping to Union<bool, DynamicMapping>
|
Ported to master 0004812 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our property mapping tests weren't sufficient as they
only tested serilization of fluent syntax and attribute
types.
This commit adds new tests that test both the fluent and
initializer types, and run them as integration tests as well
so we can validate our properties against ES.
Also tackled #2322 and #2059 as part of this, as I did a full pass over
all of our datatype mappings.