Support UpdateByQuery fluent method taking only selector delegate #2279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns with 5.x. Provide an overload to UpdateByQuery() that accepts only the selector, setting Indices and Types to T.
Mpdreamz
approved these changes
Sep 22, 2016
| ///This file contains all the typed enums that the client rest api spec exposes. | ||
| ///This file is automatically generated from https://github.com/elasticsearch/elasticsearch-rest-api-spec | ||
| ///Generated of commit v2.3.5 | ||
| namespace Elasticsearch.Net |
There was a problem hiding this comment.
I wonder why we keep on changing linefeeds in these generated files
my git config -l lists:
core.autocrlf=input
We should pick one and standardize on it.
There was a problem hiding this comment.
My bad, looks like it's me 😞
core.autocrlf=true. I'll change now to input
There was a problem hiding this comment.
Mine is also core.autocrlf=true which I thought was the recommended setting for Windows?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns with 5.x. Provide an overload to
UpdateByQuery()that accepts only the selector, settingIndicesandTypestoT. Keep existing methods for BWC