Moved the future in :on-tools-called and stored it in the db. #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The future in the :on-tools-called callback used to be just before the check for @approved*. There is really no need to have a future when the call has been rejrected, only when the call has been allowed and ready to go. So, the future was moved to just before the call. To prepare for being able to cancel the call future, the future needs to be stored in the db. This is done by a new action `set-call-future` that is called on the :execution-start event. However, the since the future starts running as soon as it s created, we have to first delay the future and then force it only after the tool call state has been transitioned to :executing.
|
I would like to run a manual test before making this PR ready for review. |
|
This PR is a part of Issue #111 and is a prerequisite for what is to follow |
ericdallo
reviewed
Sep 14, 2025
There was a problem hiding this comment.
Changes look good @bombaywalla I will test it, is there anything else you wanna do or is this ready to review?
|
I was just hoping to do a manual test, but it's ready to review otherwise. |
|
I've done some manual testing. |
|
Thank you, will review/test now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The future in the
:on-tools-calledcallback used to be just before the check for@approved*. There is really no need to have a future when the call has been rejected, only when the call has been allowed and ready to go. So, the future was moved to just before the call.To prepare for being able to cancel the call future, the future needs to be stored in the db. This is done by a new action
set-call-futurethat is called on the:execution-startevent. However, since the future starts running as soon as it s created, we have to first delay the future and then force it only after the tool call state has been transitioned to:executing.There should be no change in external behavior.